console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.9] OCPBUGS-2173: do not show NodesUpdateGroup if there are 0 nodes

Open rhamilto opened this issue 2 years ago • 12 comments

Manual back port of https://github.com/openshift/console/pull/12061

rhamilto avatar Oct 10 '22 19:10 rhamilto

@rhamilto: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] OCPBUGS-2173: do not show NodesUpdateGroup if there are 0 nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 10 '22 19:10 openshift-ci[bot]

@rhamilto: This pull request references Jira Issue OCPBUGS-2173, which is invalid:

  • expected dependent Jira Issue OCPBUGS-938 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual back port of https://github.com/openshift/console/pull/12061

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 10 '22 19:10 openshift-ci-robot

/approve

/backport-risk-assessed

rhamilto avatar Oct 10 '22 19:10 rhamilto

/retest

rhamilto avatar Oct 11 '22 11:10 rhamilto

/label backport-risk-assessed

rhamilto avatar Oct 11 '22 12:10 rhamilto

/retest

rhamilto avatar Oct 11 '22 14:10 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 12 '22 13:10 openshift-ci[bot]

/jira refresh

rhamilto avatar Oct 17 '22 14:10 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-2173, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-938 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-938 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 17 '22 14:10 openshift-ci-robot

/cherry-pick release-4.8

rhamilto avatar Oct 17 '22 14:10 rhamilto

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Before: Screen Shot 2022-10-26 at 09 53 15

After: Screen Shot 2022-10-26 at 09 54 08 /label qe-approved /label cherry-pick-approved

yapei avatar Oct 26 '22 01:10 yapei

/retest

rhamilto avatar Oct 26 '22 11:10 rhamilto

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 26 '22 14:10 openshift-ci[bot]

@rhamilto: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2173 has been moved to the MODIFIED state.

In response to this:

Manual back port of https://github.com/openshift/console/pull/12061

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 26 '22 14:10 openshift-ci-robot

@rhamilto: new pull request created: #12216

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.