console
console copied to clipboard
openshift
[WIP] Bug 2115347: Monitoring: Add support for Alertmanager negative matchers
Alertmanager now supports "negative matchers", which invert the meaning of a label / value matcher. The negative matcher checkbox changes = (value equals) into != (value does not equal) and changes =~ (value matches regex) in to !~ (value does not match regex).
This fixes a bug where Alertmanager silences with negative matchers were not handled correctly. The negative matcher flag was ignored, so they were treated as normal (= or =~) matchers.
@kyoto: This pull request references Bugzilla bug 2115347, which is invalid:
- expected the bug to target the "4.12.0" release, but it targets "---" instead
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
[WIP] Bug 2115347: Monitoring: Add support for Alertmanager negative matchers
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kyoto: This pull request references Bugzilla bug 2115347, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/bugzilla refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@kyoto: This pull request references Bugzilla bug 2115347, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
[WIP] Bug 2115347: Monitoring: Add support for Alertmanager negative matchers
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@kyoto: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jgbernalp, kyoto, spadgett
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [kyoto,spadgett]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kyoto: All pull requests linked via external trackers have merged:
Bugzilla bug 2115347 has been moved to the MODIFIED state.
In response to this:
Bug 2115347: Monitoring: Add support for Alertmanager negative matchers
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.