console
console copied to clipboard
openshift
docs: fix typo in component description
This typo is also in the docs: https://github.com/openshift/console/blob/d216f9985b72cf54f9c5d17257637c138db57610/frontend/packages/console-dynamic-plugin-sdk/docs/api.md?plain=1#L950
but I guess this is autogenerated?
Hi @mikaello. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mikaello
Once this PR has been reviewed and has the lgtm label, please assign christianvogt for approval by writing /assign @christianvogt in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@mikaello: This pull request references Jira Issue OCPBUGS-9948, which is invalid:
- expected the bug to target the "4.14.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
This typo is also in the docs: https://github.com/openshift/console/blob/d216f9985b72cf54f9c5d17257637c138db57610/frontend/packages/console-dynamic-plugin-sdk/docs/api.md?plain=1#L950
but I guess this is autogenerated?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@spadgett: This pull request references Jira Issue OCPBUGS-9948, which is invalid:
- expected the bug to target the "4.14.0" version, but it targets "4.14" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@spadgett: This pull request references Jira Issue OCPBUGS-9948, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.14.0) matches configured target version for branch (4.14.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@opayne1 FYI, we should update the OpenShift docs to fix this typo as well
/retest-required
Remaining retests: 0 against base HEAD 2ca974de2e178fe68b41b2c04246699c7cd03cf6 and 2 for PR HEAD 0d3005bc3ba8ffac2b8200539a641deb55e404a4 in total
/retest-required
Remaining retests: 0 against base HEAD 15f425a2319253da3909b7ee28d64343300cb361 and 1 for PR HEAD 0d3005bc3ba8ffac2b8200539a641deb55e404a4 in total
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-9948, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.14.0) matches configured target version for branch (4.14.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/bugzilla refresh
The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.
Retaining the bugzilla/valid-bug label as it was manually added.
In response to this:
/bugzilla refresh
The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Remaining retests: 0 against base HEAD 1b2a3e35a8b6cea4a10b2ba06b0279e27b345609 and 0 for PR HEAD 0d3005bc3ba8ffac2b8200539a641deb55e404a4 in total
/hold
Revision 0d3005bc3ba8ffac2b8200539a641deb55e404a4 was retested 3 times: holding
@mikaello could you please run yarn install on this change, this will re-generate the ts docs. Otherwise the frontend job will be failing.
@mikaello could you please run
yarn installon this change, this will re-generate the ts docs. Otherwise thefrontendjob will be failing.
Sorry for the late response! I have run yarn install and committed the changes now.
@mikaello: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, mikaello, spadgett
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/console-dynamic-plugin-sdk/OWNERS~~ [jhadvig,spadgett]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mikaello: Jira Issue OCPBUGS-9948: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-9948 has been moved to the MODIFIED state.
In response to this:
This typo is also in the docs: https://github.com/openshift/console/blob/d216f9985b72cf54f9c5d17257637c138db57610/frontend/packages/console-dynamic-plugin-sdk/docs/api.md?plain=1#L950
but I guess this is autogenerated?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.