console icon indicating copy to clipboard operation
console copied to clipboard

CONSOLE-3164: Move main nav components

Open raspbeep opened this issue 2 years ago • 9 comments

https://issues.redhat.com/browse/CONSOLE-3164

Signed-off-by: Pavel Kratochvil [email protected]

raspbeep avatar Oct 02 '22 11:10 raspbeep

Hi @raspbeep. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 02 '22 11:10 openshift-ci[bot]

/ok-to-test

TheRealJon avatar Oct 03 '22 14:10 TheRealJon

/retest

raspbeep avatar Oct 03 '22 15:10 raspbeep

/retest

raspbeep avatar Oct 04 '22 14:10 raspbeep

/retest

raspbeep avatar Oct 10 '22 07:10 raspbeep

/retest

raspbeep avatar Oct 10 '22 09:10 raspbeep

/retest

raspbeep avatar Oct 10 '22 12:10 raspbeep

/retest

raspbeep avatar Oct 19 '22 21:10 raspbeep

@raspbeep: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 20 '22 01:10 openshift-ci[bot]

@raspbeep change looks good 👍

/lgtm /approve

QE Approver: 
/assign @yapei Docs Approver: 
/assign @opayne1 PX Approver: 
/assign @RickJWagner

jhadvig avatar Oct 20 '22 14:10 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, raspbeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 20 '22 14:10 openshift-ci[bot]

QE Approver /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @RickJWagner

TheRealJon avatar Oct 20 '22 17:10 TheRealJon

@jhadvig For some reason the /assign commands didn't work in your comment, so I repeated them.

TheRealJon avatar Oct 20 '22 17:10 TheRealJon

/label px-approved

RickJWagner avatar Oct 20 '22 17:10 RickJWagner

QE run a regression testing of nav menus, no issues found

  • adding/removal of nav menus
  • pin/unpin of nav menus
  • nav menu highlights etc /label qe-approved

yapei avatar Oct 24 '22 07:10 yapei

/label docs-approved

opayne1 avatar Oct 26 '22 18:10 opayne1