console
console copied to clipboard
CONSOLE-3164: Move main nav components
Hi @raspbeep. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
/retest
/retest
/retest
/retest
/retest
/retest
@raspbeep: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@raspbeep change looks good 👍
/lgtm /approve
QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, raspbeep
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [jhadvig]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
QE Approver /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @RickJWagner
@jhadvig For some reason the /assign
commands didn't work in your comment, so I repeated them.
/label px-approved
QE run a regression testing of nav menus, no issues found
- adding/removal of nav menus
- pin/unpin of nav menus
- nav menu highlights etc /label qe-approved
/label docs-approved