console
console copied to clipboard
openshift
CONSOLE-3077: Promote ConsolePlugins API version to v1 in console repository
Story: https://issues.redhat.com/browse/CONSOLE-3077
Updating ConsolePlugin manifest, model and type in console and also Readme docs. Link to the v1 api for ConsolePlugin CRD - https://github.com/openshift/api/blob/master/console/v1/types_console_plugin.go
/assign @TheRealJon
QE Approver: /assign @zhaozhanqi Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~dynamic-demo-plugin/OWNERS~~ [TheRealJon,jhadvig]
- ~~frontend/OWNERS~~ [TheRealJon,jhadvig]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jhadvig it looks like we have an issue here, user has no way to set loadType to Lazy
- First I create a ConsolePlugin with following YAML(no i18n defined)
apiVersion: console.openshift.io/v1alpha1
kind: ConsolePlugin
metadata:
name: console-customization
spec:
displayName: 'OpenShift Console Customization Plugin'
service:
name: console-customization-plugin
namespace: console-customization-plugin
port: 9443
basePath: '/'
- Check consoleplugin metadata generated,
i18n.loadTypewas set to empty ""
$ oc get consoleplugin console-customization -o json | jq .spec.i18n.loadType
""
- then I tried to update
i18n.loadTypetoLazywith command , it shows patch completed
$ oc patch consoleplugin console-customization -p '{"spec":{"i18n":{"loadType": "Lazy"}}}' --type merge
consoleplugin.console.openshift.io/console-customization patched
- finally when I check consoleplugin metadata,
i18n.loadTypeis still empty "" while it is expected to beLazysince I updated it in step 3
$ oc get consoleplugin console-customization -o json | jq .spec.i18n.loadType
""
@yapei issue should be fixed by https://github.com/openshift/console-operator/pull/684
above reported issue has been fixed in openshift/console-operator#684, no other issues found /label qe-approved
/retest-required
Remaining retests: 0 against base HEAD 738cb1a2a87b4b97f875517799cba8e91427d240 and 2 for PR HEAD f7167de6bc6c2adef7f32832786b3207436ab102 in total
@jhadvig: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.