console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.11] OCPBUGS-1727: Allow regular users to access debug pods

Open openshift-cherrypick-robot opened this issue 2 years ago • 11 comments

This is an automated cherry-pick of #12098

/assign zherman0

@openshift-cherrypick-robot: Jira Issue OCPBUGS-1522 has been cloned as Jira Issue OCPBUGS-1727. Retitling PR to link against new bug. /retitle [release-4.11] OCPBUGS-1727: Allow regular users to access debug pods

In response to this:

This is an automated cherry-pick of #12098

/assign zherman0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 26 '22 20:09 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-1727, which is invalid:

  • expected dependent Jira Issue OCPBUGS-1522 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #12098

/assign zherman0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 26 '22 20:09 openshift-ci-robot

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-1727: Allow regular users to access debug pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 26 '22 20:09 openshift-ci[bot]

/approve

zherman0 avatar Sep 26 '22 20:09 zherman0

/assign @rhamilto - you approved the original, can you approve the cherry pick please

zherman0 avatar Sep 26 '22 20:09 zherman0

/approve

rhamilto avatar Sep 27 '22 12:09 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 27 '22 12:09 openshift-ci[bot]

/retest

zherman0 avatar Sep 28 '22 15:09 zherman0

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 28 '22 15:09 openshift-ci[bot]

/cherrypick release-4.10

zherman0 avatar Sep 29 '22 22:09 zherman0

@zherman0: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Dec 29 '22 01:12 openshift-bot

@rhamilto: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jan 03 '23 13:01 openshift-ci[bot]

/label backport-risk-assessed

rhamilto avatar Jan 03 '23 13:01 rhamilto

/bugzilla refresh

rhamilto avatar Jan 03 '23 13:01 rhamilto

@rhamilto: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jan 03 '23 13:01 openshift-ci[bot]

/jira refresh

rhamilto avatar Jan 03 '23 13:01 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-1727, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1522 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1522 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Jan 03 '23 13:01 openshift-ci-robot

/lgtm

rhamilto avatar Jan 03 '23 13:01 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 03 '23 13:01 openshift-ci[bot]

This PR has been verified with cluster-bot, now regular users are able to access debug pods now both on administrator and developer perspective /label qe-approved

XiyunZhao avatar Jan 13 '23 07:01 XiyunZhao

/label cherry-pick-approved

yanpzhan avatar Jan 13 '23 07:01 yanpzhan

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 13 '23 11:01 openshift-ci[bot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1727 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #12098

/assign zherman0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Jan 13 '23 11:01 openshift-ci-robot

@zherman0: #12100 failed to apply on top of branch "release-4.10":

Applying: Allow regular users to access debug pods
Using index info to reconstruct a base tree...
M	frontend/public/components/debug-terminal.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/debug-terminal.tsx
CONFLICT (content): Merge conflict in frontend/public/components/debug-terminal.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow regular users to access debug pods
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.