console icon indicating copy to clipboard operation
console copied to clipboard

[WIP] OU-75 Add New Queries to the Top of the Queries List.

Open zhuje opened this issue 3 years ago • 2 comments

Description: .unshift() adds new queries to the beginning of the list instead of the back.

Related: https://issues.redhat.com/browse/OU-75

Demo: Clicking on 'Add query' will add a new query to the top of the list instead of the bottom. Duplicating a query by clicking on 'Duplicate query' will also add the duplicated query to the top of the list instead of the bottom.

https://user-images.githubusercontent.com/59589720/192003513-c0e3e45c-d1c7-4c6c-98d8-890f8a7514d7.mov

zhuje avatar Sep 23 '22 16:09 zhuje

@zhuje: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Nov 07 '22 23:11 openshift-merge-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhuje Once this PR has been reviewed and has the lgtm label, please assign kyoto for approval by writing /assign @kyoto in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 07 '22 23:11 openshift-ci[bot]

@zhuje: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/backend abc686643ea58e263c1c0fd1aea449a688c99d44 link true /test backend
ci/prow/frontend abc686643ea58e263c1c0fd1aea449a688c99d44 link true /test frontend
ci/prow/e2e-gcp-console abc686643ea58e263c1c0fd1aea449a688c99d44 link true /test e2e-gcp-console
ci/prow/analyze abc686643ea58e263c1c0fd1aea449a688c99d44 link true /test analyze
ci/prow/images abc686643ea58e263c1c0fd1aea449a688c99d44 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 07 '22 23:11 openshift-ci[bot]

Closed -- separate PR created with another approach.

zhuje avatar Nov 17 '22 15:11 zhuje