console icon indicating copy to clipboard operation
console copied to clipboard

Make dynamic plugin dependencies optional

Open vojtechszocs opened this issue 2 years ago • 3 comments

  • Plugin metadata field dependencies is now optional.
  • Plugin dependency @console/pluginAPI is now optional. If missing, the Console version check is skipped.
  • Existing plugins with @console/pluginAPI dependency (regardless of version range used) are not affected.
  • Removed @console/pluginAPI dependency from dynamic demo plugin.
  • Updated README to account for semver pre-release specifics when declaring plugin dependencies.

vojtechszocs avatar Sep 21 '22 17:09 vojtechszocs

/retest

vojtechszocs avatar Oct 03 '22 17:10 vojtechszocs

QE Approver: /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @RickJWagner

Console Approver: /assign @jhadvig

vojtechszocs avatar Oct 20 '22 16:10 vojtechszocs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 20 '22 16:10 openshift-ci[bot]

/label px-approved

RickJWagner avatar Oct 20 '22 17:10 RickJWagner

@jhadvig is this another one we need to update from plugin to plug-in? I am going to go ahead and add the label though.

opayne1 avatar Oct 21 '22 17:10 opayne1

/label docs-approved

opayne1 avatar Oct 21 '22 17:10 opayne1

QE tested the changes, confirmed that plugin metadata fielddependencies is now optional(plugin still work without dependencies) and no regressions(existing plugins with dependencies still work) /label qe-approved

yapei avatar Oct 25 '22 08:10 yapei