console
console copied to clipboard
openshift
ODC-6779 - Hide sub-catalog(s) in the developer catalog or the entire dev catalog based on customization
JIRA story: https://issues.redhat.com/browse/ODC-6779
Description: This story is about the customization of developer catalog and sub-catalog based on customization. If all the available sub-catalogs(types) are disabled, complete developer catalog along with the entry points to the catalog will be disabled.
Screenshots:
----When all the sub-catalogs are disabled - Add page----
----When all the sub-catalogs are disabled - Topology page----
-----Quick start when complete developer catalog is disabled-----
------ All services - when all the sub-catalogs(types) are enabled----
------ All services - when Templates and Helm charts sub-catalogs are disabled----
-----Helm Page when helm chart sub-catalog is disabled-----
---- Operator hub description when operator backed service is disabled or complete developer catalog is disabled---
---- If Event source type is disabled, create event source in action menu is hidden----
-----If user try to reach to catalog by entering URL and if that sub-catalog is disabled, then user will see Page not found--
Test cases:
How to test:
If backend API PR's - https://github.com/openshift/api/pull/1256 & https://github.com/openshift/console-operator/pull/676 are not merged then to add the customization use below method,
Pass options as a string to bridge with -developer-catalog-disabled-types or pass a ConsoleConfig yaml with -config option.
Example:
Specify developer catalog types to bridge with ./bin/bridge -developer-catalog-types '{ "state": "Disabled" ,"disabled": ["HelmChart", "Devfile"] }'.
This indicated HelmChart and Devfile sub-catalogs are disabled. Similarly below are the test scenarios,
If the state is Enabled and enabled list is empty, all the types will be shown.
If the state id Enabled and enabled list is non-empty, only the enabled list items will be shown.
If the state is Disabled and disabled list is empty, all the types will be hidden.
If the state id Disabled and disabled list is non-empty, only the disabled list items will be hidden.
To disable the complete developer catalog then in disabled all the available types
should be listed or make the disabled list empty for state: Disabled.
/kind feature
Hi @jerolimov / @debsmita1 ,
Updated the PR as per the PR comments.
@lokanandaprabhu While testing your pr on cluster-bot, I saw this scenario:
- I enabled the dev catalog for Helm charts only
- When I switch to topology after a hard refresh
- I can see the Database card, is this an expected behavior Screencast from 10-12-2022 07:21:44 PM.webm
@lokanandaprabhu While testing your pr on cluster-bot, I saw this scenario:
- I enabled the dev catalog for Helm charts only
- When I switch to topology after a hard refresh
- I can see the Database card, is this an expected behavior Screencast from 10-12-2022 07:21:44 PM.webm
Yes, Database will be enabled when atleast one sub-catalog is enabled. Database will be disabled only when the complete developer catalog is disabled.
-
Event source option is present in the connector context menu which leads to a 404 page. Even after disabling the Event Source catalog. See the GIF
-
Event Sink option is also present in the connector context menu. And in the action menu of the broker which leads to a 404 page.
- On disabling the complete catalogs. Should we hide the
Create applications using samplesfrom theGetting started resourcescard asView all sampleslinks leads to an empty Sample catalog page?
The entire dev-catalog is disabled, but I can see Samples option when I click on topology graph
https://user-images.githubusercontent.com/22490998/195789490-c2df4321-a88d-4c1b-82c1-ac5e4a05cccc.mov
The entire dev-catalog is disabled, but I can see
Samplesoption when I click on topology graph https://user-images.githubusercontent.com/22490998/195789490-c2df4321-a88d-4c1b-82c1-ac5e4a05cccc.mov
Updated the PR.
Following our no-FF process propagate the PX and Docs ACK from epic ODC-5897 /label px-approved /label docs-approved
I add also approve here so that @debsmita1 can do the final review when the files are moved (https://github.com/openshift/console/pull/12067#pullrequestreview-1143240309) and the PR is rebased. /approve
Hi @jerolimov / @debsmita1 ,
I have updated the PR based on PR comments. PTAL. Thanks.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jerolimov, lokanandaprabhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [jerolimov]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD 167ca3743c4766f5c2075543052a3d35e728598c and 2 for PR HEAD 59b26fbde2639f340e2796b2f2971139ea3a5a6f in total
@lokanandaprabhu: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.