openshift
OCPBUGS-505: Input box aria-label and name wrong for editing PDB inside Deployments
@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-505, which is invalid:
- expected the bug to target the "4.12.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Before
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-505, which is invalid:
- expected the bug to target the "4.12.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Before
After###
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Should we simplify things and make the aria-label and name more generic rather than adding more state?
@TheRealJon That's fine with me. Thanks
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cyril-ui-developer, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [TheRealJon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-505, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.12.0) matches configured target version for branch (4.12.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Remaining retests: 0 against base HEAD 45a6496ff5b10d885e3b1013f5bdec078d811f2b and 2 for PR HEAD 302f51c5cacb4683e5a601422406c0431ff288b2 in total
/retest-required
Remaining retests: 0 against base HEAD 738cb1a2a87b4b97f875517799cba8e91427d240 and 1 for PR HEAD 302f51c5cacb4683e5a601422406c0431ff288b2 in total
@cyril-ui-developer: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@cyril-ui-developer: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-505 has been moved to the MODIFIED state.
In response to this:
Before
After###
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.