Bug 2115424: Helm chart Nodejs Ex K could not be installed via Form view

[Lucifergene]

Fixes:

https://issues.redhat.com/browse/OCPBUGSM-47478

Analysis / Root cause:

Helm Chart "Nodejs Ex K" could not be installed via form mode.

Solution Description:

The formData was being passed into a Prune function, which was used to remove all the empty and null objects and their keys. This caused the issue since for the form to be successfully executed, some of these deleted keys were required.

As the solution, the call to the Prune function is cancelled.

Screen shots / Gifs for design review:

https://user-images.githubusercontent.com/47265560/190225629-d8852d8c-ecb1-46ce-9114-28d27fb72c66.mp4

Unit test coverage report:

No Changes

Test setup:

1. Switch to Developer perspective
2. Navigate to Add > Helm Chart (catalog)
3. Search for nodejs and select "Nodejs Ex K"
4. Click on "Install Helm Chart"
5. Ensure the form view is opened (as yaml works fine)
6. Press Install

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari
• [ ] Edge

[openshift-ci[bot]]

@Lucifergene: This pull request references Bugzilla bug 2115424, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

Bug 2115424: Helm chart Nodejs Ex K could not be installed via Form view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lucifergene Once this PR has been reviewed and has the lgtm label, please assign sahil143 for approval by writing /assign @sahil143 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/packages/helm-plugin/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Lucifergene]

/cc @jerolimov @rottencandy

[Lucifergene]

/retest

[openshift-ci[bot]]

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Lucifergene]

I verified the setup defined in ODC-6225. The error is not recurring anymore. (Verified in OpenShift version: 4.12.0-0.ci-2022-09-14-225342)

https://user-images.githubusercontent.com/47265560/190432520-dd315096-4e81-4a47-a505-5bea73e0c737.mp4

[rottencandy]

I think the problem happens when switching before changing values.

https://user-images.githubusercontent.com/20013884/190591176-05244085-6ed1-43c6-a089-5bd9763dd58c.mp4

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[Lucifergene]

/remove-lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christoph-jerolimov]

/remove-lifecycle stale

[christoph-jerolimov]

/retitle OCPBUGS-9447: Helm chart Nodejs Ex K could not be installed via Form view

[openshift-ci[bot]]

@Lucifergene: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-9447: Helm chart Nodejs Ex K could not be installed via Form view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@Lucifergene: This pull request references Jira Issue OCPBUGS-9447, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGSM-47478

Analysis / Root cause:

Helm Chart "Nodejs Ex K" could not be installed via form mode.

Solution Description:

The formData was being passed into a Prune function, which was used to remove all the empty and null objects and their keys. This caused the issue since for the form to be successfully executed, some of these deleted keys were required.

As the solution, the call to the Prune function is cancelled.

Screen shots / Gifs for design review:

https://user-images.githubusercontent.com/47265560/190225629-d8852d8c-ecb1-46ce-9114-28d27fb72c66.mp4

Unit test coverage report:

No Changes

Test setup:

1. Switch to Developer perspective
2. Navigate to Add > Helm Chart (catalog)
3. Search for nodejs and select "Nodejs Ex K"
4. Click on "Install Helm Chart"
5. Ensure the form view is opened (as yaml works fine)
6. Press Install

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@Lucifergene: This pull request references Jira Issue OCPBUGS-9447. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGSM-47478

Analysis / Root cause:

Helm Chart "Nodejs Ex K" could not be installed via form mode.

Solution Description:

The formData was being passed into a Prune function, which was used to remove all the empty and null objects and their keys. This caused the issue since for the form to be successfully executed, some of these deleted keys were required.

As the solution, the call to the Prune function is cancelled.

Screen shots / Gifs for design review:

https://user-images.githubusercontent.com/47265560/190225629-d8852d8c-ecb1-46ce-9114-28d27fb72c66.mp4

Unit test coverage report:

No Changes

Test setup:

1. Switch to Developer perspective
2. Navigate to Add > Helm Chart (catalog)
3. Search for nodejs and select "Nodejs Ex K"
4. Click on "Install Helm Chart"
5. Ensure the form view is opened (as yaml works fine)
6. Press Install

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lucifergene

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Lucifergene]

Continuing the work on another PR. Attaching Link here once the new PR is up

[openshift-ci[bot]]

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.