console
console copied to clipboard
openshift
OCPBUGS-800: Name of workload get changed, when project and image stream gets changed on reloading the form on the edit deployment page of the workload
Fixes: https://issues.redhat.com/browse/OCPBUGS-800
Analysis / Root cause: Name of workload get changed, when project and image stream gets changed on reloading the form on the edit deployment page of the workload
Solution Description:
Reset the formType when the Reload button is pressed.
Screen shots / Gifs for design review:
https://user-images.githubusercontent.com/47265560/188634133-b83b2eca-cd78-4fd4-b7f3-fa033fd7e479.mp4
Unit test coverage report:
Not changed.
Test setup:
- Create a deployment workload
- Select Edit Deployment option on workload
- Verify initially name was same as workload name and field was not changeable.
- Change the project to "openshift", image stream to "golang" or anything and tag to "latest"
- Reload the form
- Now check that the name also got changed to golang.
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
- [ ] Edge
@Lucifergene: This pull request references Jira Issue OCPBUGS-800, which is invalid:
- expected the bug to target the "4.12.0" version, but it targets "4.12.z" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Fixes: https://issues.redhat.com/browse/OCPBUGS-800
Analysis / Root cause: Name of workload get changed, when project and image stream gets changed on reloading the form on the edit deployment page of the workload
Solution Description:
Reset the formType when the Reload button is pressed.
Screen shots / Gifs for design review:
https://user-images.githubusercontent.com/47265560/188634133-b83b2eca-cd78-4fd4-b7f3-fa033fd7e479.mp4
Unit test coverage report:
Not changed.
Test setup:
- Create a deployment workload
- Select Edit Deployment option on workload
- Verify initially name was same as workload name and field was not changeable.
- Change the project to "openshift", image stream to "golang" or anything and tag to "latest"
- Reload the form
- Now check that the name also got changed to golang.
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
- [ ] Edge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@Lucifergene: This pull request references Jira Issue OCPBUGS-800, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.12.0) matches configured target version for branch (4.12.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: divyanshiGupta, Lucifergene
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [divyanshiGupta]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Lucifergene: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@Lucifergene: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-800 has been moved to the MODIFIED state.
In response to this:
Fixes: https://issues.redhat.com/browse/OCPBUGS-800
Analysis / Root cause: Name of workload get changed, when project and image stream gets changed on reloading the form on the edit deployment page of the workload
Solution Description:
Reset the formType when the Reload button is pressed.
Screen shots / Gifs for design review:
https://user-images.githubusercontent.com/47265560/188634133-b83b2eca-cd78-4fd4-b7f3-fa033fd7e479.mp4
Unit test coverage report:
Not changed.
Test setup:
- Create a deployment workload
- Select Edit Deployment option on workload
- Verify initially name was same as workload name and field was not changeable.
- Change the project to "openshift", image stream to "golang" or anything and tag to "latest"
- Reload the form
- Now check that the name also got changed to golang.
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
- [ ] Edge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.