CONSOLE 3250: Configure default behavior for "Wrap lines" in log viewers

[sg00dwin]

Add the ability to include a pod annotation console.openshift.io/wrap-log-lines which will default the log viewer to wrap log lines. https://issues.redhat.com/browse/CONSOLE-3250

@jhadvig @TheRealJon there is a consequence of this change. Since wrapLines is stored in local storage, if a user has selected to turn off wrap lines checkbox in the past and then views the log of a pod with the configured default wrap annotation, then this "wrapped" preference will persist to subsequent pod logs. Is this behavior acceptable?

cc @rhamilto

Example: The left side pod has console.openshift.io/wrap-log-lines annotation. On the right side, the pod wrap lines setting is unchecked. Once user has viewed left side pod logs with default wrap config, then subsequent pod log settings are switched to wrapped.

[sg00dwin]

/retest

[sg00dwin]

The PR has been updated to check if the pod annotation console.openshift.io/wrap-log-lines: 'true' if so default log lines to wrapped. The wrap lines checkbox can be toggled off to unwrap lines. And the local storage preference is not effected.

[jhadvig]

/assign @rhamilto

[sg00dwin]

Screencast showing local storage preference not changing when viewing pod with wraplines annotation.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, jhadvig, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[RickJWagner]

/label px-approved

[jcaianirh]

Not sure which qe person to tag, so adding Ya Dan /assign @yapei

[jcaianirh]

Docs approval: /assign @opayne1

[jcaianirh]

QE aprroval: 
/assign @zhigwang

[jcaianirh]

/assign @yanpzhan

[opayne1]

/label docs-approved

[yanpzhan]

@sg00dwin after test the pr, I found pod with annotation "console.openshift.io/wrap-log-lines: 'false'" has the same behavior with pod without this annotation, is it expected? I've pasted new case link in jira issue, pls help to review, thanks!

[sg00dwin]

@sg00dwin after test the pr, I found pod with annotation "console.openshift.io/wrap-log-lines: 'false'" has the same behavior with pod without this annotation, is it expected? I've pasted new case link in jira issue, pls help to review, thanks!

@yanpzhan A pod with the annotation console.openshift.io/wrap-log-lines: 'false' would have the same behavior as a pod without the annotation. Only console.openshift.io/wrap-log-lines: 'true' should wrap the lines.

[jcaianirh]

@yanpzhan just checking to see if this has passed qe tests and is ready for qe-approved label. Thanks!

[yanpzhan]

@sg00dwin I didn't found issue when tested the pr again, and the checkpoints for the pr/US are added in new case, Could you help to review test case if there is checkpoint missed?

[sg00dwin]

@sg00dwin I didn't found issue when tested the pr again, and the checkpoints for the pr/US are added in new case, Could you help to review test case if there is checkpoint missed?

@yanpzhan the test cases are approved

[yanpzhan]

/label qe-approved

[rhamilto]

/retest

[rhamilto]

/retest

[openshift-ci[bot]]

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.