openshift
CONSOLE-3284: SPIKE: Transform namespaces from old i18next format into the new one
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cyril-ui-developer
Once this PR has been reviewed and has the lgtm label, please assign kyoto for approval by writing /assign @kyoto in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Have we confirmed that transformNamespace doesn't break plugins already using the new plural format?
Thanks @cyril-ui-developer. Should we run the transformation on the other language json files as well to clean those up?
How does this change the po files that we send to the globalization team? I am curious if this breaks translation memory for anything that uses plurals and if the translators will have enough context to understand what
_oneand_othermeans in the message keys.
@spadgett No, I don't think we need to run the transformation to clean up non-en languages. It seems they don't use _plural suffix for pluralization. However I don't really understand how non-en plural works.
https://github.com/openshift/console/blob/master/frontend/public/locales/ja/public.json#L447
I think we need to reach out to localization team on the po files concern. I will check with Terry.
Have we confirmed that
transformNamespacedoesn't break plugins already using the new plural format?
@spadgett I tested by running the transformNamespace on all locales including public, and it didn't fail if the messages were already in the new format. However I will double check by building a dynamic plugin demo image with a new format.
@cyril-ui-developer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp-console | 15a1c14c47b1cfb9e30b2b8dc0a43c9608cdd748 | link | true | /test e2e-gcp-console |
| ci/prow/frontend | 15a1c14c47b1cfb9e30b2b8dc0a43c9608cdd748 | link | true | /test frontend |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.