console
console copied to clipboard
create kafkaSink support in catalog
Fixes: https://issues.redhat.com/browse/ODC-6756
Solution Description:
Adds support for kafkaSink
- KafkaSink should show up in eventSinks with Red Hat as a provider
- Show form/yaml view for kakaSink
Screenshots / Gifs for design review:

Test setup:
- Install Serverless operator and create CR for
knativeServing, knativeEventing and kantiveKafka with sink enabled
TODO:
- [x] add e2e tests for kafka sink creation
- [x] add unit tests
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
/cc @vikram-raj @sanketpathak
There is no http(s) schema for Kafka, it's a different protocol, but I understand these are dummy mocks.
Besides from that the graphics / gifs are looking good, IMO
LGTM
Thanks @sanketpathak @divyanshiGupta, have updated based on review comments PTAL
/retest
/retest
@invincibleJai It seems like form validation is not working properly as I am seeing the error messages on opening the form without having touched any fields.
@invincibleJai It seems like form validation is not working properly as I am seeing the error messages on opening the form without having touched any fields.
![]()
Okay it looks like this is not the form that you added. This is a dynamic form.
Tested on cluster-bot created using pr, working fine
/label qe-approved
Propagating docs and px acks from the Epic ODC-6741 /label docs-approved /label px-approved
/retest-required
Remaining retests: 2 against base HEAD 9e8d2710b28d0a97ce402f5bc4b808aaf06f96f6 and 8 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total
/retest-required
Remaining retests: 2 against base HEAD e1c02e10faaa9199e24b5f631337259c9f497e22 and 7 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total
/retest-required
Remaining retests: 1 against base HEAD e1c02e10faaa9199e24b5f631337259c9f497e22 and 6 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total
/retest-required
Remaining retests: 0 against base HEAD e1c02e10faaa9199e24b5f631337259c9f497e22 and 5 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total
/retest
/lgtm
@invincibleJai: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: divyanshiGupta, invincibleJai
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/integration-tests/OWNERS~~ [divyanshiGupta,invincibleJai]
- ~~frontend/packages/knative-plugin/OWNERS~~ [divyanshiGupta,invincibleJai]
- ~~frontend/packages/topology/integration-tests/OWNERS~~ [divyanshiGupta,invincibleJai]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment