console icon indicating copy to clipboard operation
console copied to clipboard

create kafkaSink support in catalog

Open invincibleJai opened this issue 3 years ago • 5 comments
trafficstars

Fixes: https://issues.redhat.com/browse/ODC-6756

Solution Description:

Adds support for kafkaSink

  • KafkaSink should show up in eventSinks with Red Hat as a provider
  • Show form/yaml view for kakaSink

Screenshots / Gifs for design review:

image image

createKafkaSink2

Test setup:

  • Install Serverless operator and create CR for knativeServing, knativeEventing and kantiveKafka with sink enabled

TODO:

  • [x] add e2e tests for kafka sink creation
  • [x] add unit tests
image image

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

invincibleJai avatar Aug 10 '22 11:08 invincibleJai

/cc @vikram-raj @sanketpathak

invincibleJai avatar Aug 11 '22 13:08 invincibleJai

There is no http(s) schema for Kafka, it's a different protocol, but I understand these are dummy mocks.

Besides from that the graphics / gifs are looking good, IMO

matzew avatar Aug 15 '22 06:08 matzew

LGTM

matzew avatar Aug 15 '22 06:08 matzew

Thanks @sanketpathak @divyanshiGupta, have updated based on review comments PTAL

invincibleJai avatar Aug 19 '22 15:08 invincibleJai

/retest

invincibleJai avatar Aug 22 '22 05:08 invincibleJai

/retest

invincibleJai avatar Aug 22 '22 14:08 invincibleJai

@invincibleJai It seems like form validation is not working properly as I am seeing the error messages on opening the form without having touched any fields.

Screenshot 2022-08-23 at 5 05 00 PM

divyanshiGupta avatar Aug 23 '22 11:08 divyanshiGupta

@invincibleJai It seems like form validation is not working properly as I am seeing the error messages on opening the form without having touched any fields.

Screenshot 2022-08-23 at 5 05 00 PM

Okay it looks like this is not the form that you added. This is a dynamic form.

divyanshiGupta avatar Aug 23 '22 11:08 divyanshiGupta

Tested on cluster-bot created using pr, working fine Screenshot from 2022-08-23 15-58-39 /label qe-approved

sanketpathak avatar Aug 23 '22 13:08 sanketpathak

Propagating docs and px acks from the Epic ODC-6741 /label docs-approved /label px-approved

invincibleJai avatar Aug 23 '22 13:08 invincibleJai

/retest-required

Remaining retests: 2 against base HEAD 9e8d2710b28d0a97ce402f5bc4b808aaf06f96f6 and 8 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total

openshift-ci-robot avatar Aug 23 '22 20:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD e1c02e10faaa9199e24b5f631337259c9f497e22 and 7 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total

openshift-ci-robot avatar Aug 23 '22 23:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD e1c02e10faaa9199e24b5f631337259c9f497e22 and 6 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total

openshift-ci-robot avatar Aug 24 '22 00:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD e1c02e10faaa9199e24b5f631337259c9f497e22 and 5 for PR HEAD 74872249d0493eab901b5381dcd945c6a2c1d3da in total

openshift-ci-robot avatar Aug 24 '22 03:08 openshift-ci-robot

/retest

invincibleJai avatar Aug 24 '22 06:08 invincibleJai

/lgtm

divyanshiGupta avatar Aug 24 '22 07:08 divyanshiGupta

@invincibleJai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 24 '22 11:08 openshift-ci[bot]

/lgtm

divyanshiGupta avatar Aug 24 '22 11:08 divyanshiGupta

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 24 '22 11:08 openshift-ci[bot]