console icon indicating copy to clipboard operation
console copied to clipboard

Update pf packages to pf-2022-9

Open jcaianirh opened this issue 3 years ago • 12 comments

In the future, PF will remove the react-measure package as it isn't compatible with react 18. This will cause errors on our end because we relied on their react-measure type dependency. Added that dependency into our package.json as well as our dynamic plugin package.json. Created a story to follow pf and move to react-resize-detector as tech debt before moving to react 18: https://issues.redhat.com/browse/CONSOLE-3247

jcaianirh avatar Aug 08 '22 16:08 jcaianirh

@jerolimov made some react-measure updates to compensate for pf removing it

jcaianirh avatar Aug 08 '22 21:08 jcaianirh

QE Approver: /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @RickJWagner

Console Approver: /assign @jhadvig

LGTM Approver: /assign @sg00dwin

jcaianirh avatar Aug 08 '22 21:08 jcaianirh

/retest

jcaianirh avatar Aug 09 '22 03:08 jcaianirh

@jcaianirh Hi, I launched a cluster against the pr, did some regression test on console pages, such as catalog page/tables/metrics/charts/topology and so on. Is it enough? if there is special checkpoint need to be tested?

yanpzhan avatar Aug 09 '22 11:08 yanpzhan

/label docs-approved

opayne1 avatar Aug 09 '22 12:08 opayne1

/retest

jcaianirh avatar Aug 09 '22 13:08 jcaianirh

/label px-approved

RickJWagner avatar Aug 09 '22 18:08 RickJWagner

/label qe-approved

yanpzhan avatar Aug 10 '22 11:08 yanpzhan

/retest

jcaianirh avatar Aug 11 '22 14:08 jcaianirh

/lgtm

zherman0 avatar Aug 15 '22 14:08 zherman0

/label tide/merge-method-squash

/approve

/lgtm

rhamilto avatar Aug 22 '22 18:08 rhamilto

/approve

rhamilto avatar Aug 22 '22 18:08 rhamilto

/lgtm

rhamilto avatar Aug 22 '22 18:08 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rhamilto, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 22 '22 18:08 openshift-ci[bot]

@jcaianirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 23 '22 03:08 openshift-ci[bot]