openshift
Bug 2115899: Change image repository to image registry
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2115899
Analysis / Root cause: OpenShift is all about standard container images and standard container image registries, btw. called registries, not repositories.
See also https://docs.openshift.com/container-platform/4.10/registry/index.html
Solution Description: Updated the labels:
Screen shots / Gifs for design review:
| Page | Before | After |
|---|---|---|
| Edit BuildConfig |  |
 |
| Add > Import from container |  |
 |
Unit test coverage report: Unchanged
Test setup: Unchanged
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
/cc @serenamarie125
@jerolimov: This pull request references Bugzilla bug 2115899, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
Bug 2115899: Change image repository to image registry
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
LGTM! As discussed, we should be using image registry, not image repository. Could you update the screenshot you have for the Edit BuildConfig? Thanks!
@jerolimov: This pull request references Bugzilla bug 2115899, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
[WIP] Bug 2115899: BuildConfig form: Change image repository to image registry
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
LGTM! As discussed, we should be using image registry, not image repository. Could you update the screenshot you have for the Edit BuildConfig? Thanks!
Updated the "image repository" to "image registry" on the BuildConfig edit page as well.
Updated the Solution Description section and screenshots in my first comment.
/cc @debsmita1 @invincibleJai
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: invincibleJai, jerolimov, serenamarie125
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [invincibleJai,jerolimov]
- ~~frontend/packages/shipwright-plugin/OWNERS~~ [invincibleJai,jerolimov]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jerolimov: All pull requests linked via external trackers have merged:
Bugzilla bug 2115899 has been moved to the MODIFIED state.
In response to this:
Bug 2115899: BuildConfig form: Change image repository to image registry
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.