console
console copied to clipboard
openshift
Migrates StorageClass Provisioner to dynamic-plugin-sdk
- Introduces a new Extension Point
console.storage-class/provisioner. - Moves all the default provisioners to
console-appand injects it via extension point. - Refactors
storage-class-form.tsxand remove usage of static extension points. - Removes
StorageClass/Provisionerstatic extension point and all it's usage. - Migrate ODF usage of extension from static to dynamic paradigm.
Recording:
https://user-images.githubusercontent.com/54092533/182795207-e3991ed7-1e73-49c4-825b-bb326af36724.mp4
Created as https://github.com/openshift/console/pull/8345 could not be reopened.
@spadgett there are unit tests associated with it and an example extension is being pushed in there. Would it suffice or should we go for e2e tests as well? (Also our CI runs on GCP and we mostly work on AWS)
@spadgett there are unit tests associated with it and an example extension is being pushed in there. Would it suffice or should we go for e2e tests as well? (Also our CI runs on GCP and we mostly work on AWS)
I was thinking more about testing the storage class creation form for each provider. There are so many it would be easy to regress.
Thank you for providing the video snippet, this is a great help in px review.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bipuladh, SanjalKatiyar, spadgett
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [spadgett]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 2 against base HEAD d797904316ca184ef914d260fe18d3f9e55c790d and 8 for PR HEAD 9406d4814c039b70c3f17e1fd180c23a748a2c55 in total
/retest-required
Remaining retests: 1 against base HEAD d797904316ca184ef914d260fe18d3f9e55c790d and 7 for PR HEAD 9406d4814c039b70c3f17e1fd180c23a748a2c55 in total
/retest-required
Remaining retests: 0 against base HEAD d797904316ca184ef914d260fe18d3f9e55c790d and 6 for PR HEAD 9406d4814c039b70c3f17e1fd180c23a748a2c55 in total
/retest-required
Remaining retests: 2 against base HEAD a7ec144a316e06dbbfab0bf6596fa86cea9e5dc0 and 5 for PR HEAD 9406d4814c039b70c3f17e1fd180c23a748a2c55 in total
/retest-required
Remaining retests: 2 against base HEAD a10ddfcfffaaf2f5f43e90e68f2d0482543dcfec and 4 for PR HEAD 9406d4814c039b70c3f17e1fd180c23a748a2c55 in total
/retest-required
Remaining retests: 1 against base HEAD a10ddfcfffaaf2f5f43e90e68f2d0482543dcfec and 3 for PR HEAD 9406d4814c039b70c3f17e1fd180c23a748a2c55 in total