console icon indicating copy to clipboard operation
console copied to clipboard

Bug 2112999: Replace sum_irate with sum_rate for Deployments CPU graph

Open juanrh opened this issue 2 years ago • 18 comments

In in OCP 4.8 the metric node_namespace_pod_container:container_cpu_usage_seconds_total:sum_irate is not available, what is available is the same metric but using sum_rate instead. CMO replaced sum_rate with sum_irate in 4.9 through an update on a transitive dependency. This bug was introduced by cherry-picking a change for 4.9 that assumes sum_irate is available.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2112999

juanrh avatar Aug 02 '22 08:08 juanrh

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Aug 02 '22 08:08 openshift-ci[bot]

@juanrh: This pull request references Bugzilla bug 2112999, which is invalid:

  • expected dependent Bugzilla bug 2112995 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 2112996 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 2112995 to target a release in 4.9.0, 4.9.z, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2112999: Replace sum_irate with sum_rate for Deployments CPU graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 02 '22 08:08 openshift-ci[bot]

/bugzilla refresh

juanrh avatar Aug 11 '22 07:08 juanrh

@juanrh: This pull request references Bugzilla bug 2112999, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2112996 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2112996 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 11 '22 07:08 openshift-ci[bot]

/retest

juanrh avatar Aug 11 '22 07:08 juanrh

/test all

juanrh avatar Aug 11 '22 07:08 juanrh

/lgtm /retest

simonpasquier avatar Aug 11 '22 10:08 simonpasquier

/approve

kyoto avatar Aug 15 '22 04:08 kyoto

/cc @spadgett (for backport-risk-assessed review)

kyoto avatar Aug 15 '22 04:08 kyoto

/retest-required

juanrh avatar Aug 16 '22 08:08 juanrh

/retest-required

spadgett avatar Aug 16 '22 15:08 spadgett

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanrh, kyoto, simonpasquier, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 16 '22 15:08 openshift-ci[bot]

tested with PR, could see the CPU usage graph for deployment. /label qe-approved

juzhao avatar Aug 17 '22 08:08 juzhao

/label cherry-pick-approved

juzhao avatar Aug 17 '22 08:08 juzhao

/retest-required

Remaining retests: 2 against base HEAD a0b71365c8aa1b9b9c732e4d6eb8b0cd4eafc345 and 8 for PR HEAD 836954a0ecc4a1daaf4d2007e2503ebd7c875211 in total

openshift-ci-robot avatar Aug 17 '22 08:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD a0b71365c8aa1b9b9c732e4d6eb8b0cd4eafc345 and 7 for PR HEAD 836954a0ecc4a1daaf4d2007e2503ebd7c875211 in total

openshift-ci-robot avatar Aug 17 '22 11:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD a0b71365c8aa1b9b9c732e4d6eb8b0cd4eafc345 and 6 for PR HEAD 836954a0ecc4a1daaf4d2007e2503ebd7c875211 in total

openshift-ci-robot avatar Aug 17 '22 13:08 openshift-ci-robot

/retest-required

juanrh avatar Aug 18 '22 07:08 juanrh

/retest-required

juanrh avatar Aug 19 '22 07:08 juanrh

/retest-required

juanrh avatar Aug 19 '22 09:08 juanrh

/retest-required

juanrh avatar Aug 22 '22 07:08 juanrh

/retest

kyoto avatar Aug 23 '22 00:08 kyoto

There is bug in the UI tests that was fixed in 4.11 and that was back ported to 4.10 in https://github.com/openshift/console/pull/11966, and it is currently WIP for 4.9 in https://github.com/openshift/console/pull/11977. Waiting for the fix to get to 4.8

juanrh avatar Aug 23 '22 08:08 juanrh

/retest-required

Remaining retests: 2 against base HEAD f9d68eaf6dc906cb2be7ec969b80fb7e4c4b5b74 and 5 for PR HEAD 836954a0ecc4a1daaf4d2007e2503ebd7c875211 in total

openshift-ci-robot avatar Aug 29 '22 07:08 openshift-ci-robot

/retest-required

invincibleJai avatar Aug 29 '22 10:08 invincibleJai

@juanrh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 29 '22 13:08 openshift-ci[bot]

@juanrh: All pull requests linked via external trackers have merged:

Bugzilla bug 2112999 has been moved to the MODIFIED state.

In response to this:

Bug 2112999: Replace sum_irate with sum_rate for Deployments CPU graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 29 '22 13:08 openshift-ci[bot]