console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.11] Bug 2109887: remove redundant model check to prevent tab reloading

Open rhamilto opened this issue 2 years ago • 10 comments

since ModelStatusBox is already checking for the model

rhamilto avatar Jul 29 '22 12:07 rhamilto

@rhamilto: This pull request references Bugzilla bug 2037329, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.12.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 2037329 to depend on a bug targeting a release in 4.12.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2037329: remove redundant model check to prevent tab reloading

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 29 '22 12:07 openshift-ci[bot]

@rhamilto: This pull request references Bugzilla bug 2109887, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.11.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.11] Bug 2109887: remove redundant model check to prevent tab reloading

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 29 '22 12:07 openshift-ci[bot]

/backport-risk-assessed

rhamilto avatar Jul 29 '22 12:07 rhamilto

/retest

rhamilto avatar Jul 29 '22 15:07 rhamilto

/retest

rhamilto avatar Jul 29 '22 19:07 rhamilto

/retest

rhamilto avatar Aug 01 '22 11:08 rhamilto

/retest

rhamilto avatar Aug 01 '22 15:08 rhamilto

https://github.com/openshift/console/pull/11916 should unblock the failing test

rhamilto avatar Aug 01 '22 18:08 rhamilto

/retest

rhamilto avatar Aug 19 '22 14:08 rhamilto

/bugzilla refresh

rhamilto avatar Aug 19 '22 14:08 rhamilto

@rhamilto: This pull request references Bugzilla bug 2109887, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.z) matches configured target release for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2037329 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2037329 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 19 '22 14:08 openshift-ci[bot]

/lgtm

rhamilto avatar Aug 19 '22 14:08 rhamilto

@rhamilto: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 19 '22 14:08 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 19 '22 14:08 openshift-ci[bot]

/retest

rhamilto avatar Aug 19 '22 18:08 rhamilto

/retest

rhamilto avatar Aug 22 '22 12:08 rhamilto

/label qe-approved /label cherry-pick-approved

yapei avatar Sep 07 '22 09:09 yapei

/retest-required

Remaining retests: 0 against base HEAD 3443768724c4ca1d0453effe4224525827b40ca7 and 2 for PR HEAD 23d0251c61ab400728fd555178b35a55eb351972 in total

openshift-ci-robot avatar Sep 07 '22 13:09 openshift-ci-robot

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 07 '22 17:09 openshift-ci[bot]

@rhamilto: All pull requests linked via external trackers have merged:

Bugzilla bug 2109887 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2109887: remove redundant model check to prevent tab reloading

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 07 '22 17:09 openshift-ci[bot]