console icon indicating copy to clipboard operation
console copied to clipboard

[WIP]Upgrade @types/react-redux to v7.1.24

Open divyanshiGupta opened this issue 3 years ago • 8 comments
trafficstars

Fixes: https://issues.redhat.com/browse/ODC-6493

Due to out-of-sync @types/react-redux version few imports such as useSelector from react-redux was showing errors. So ts-ignore was used and also because of that @typescript-eslint/ban-ts-ignore rule was disabled for these lines. This PR:

  • Upgrades @types/react-redux to v7.1.24
  • Removes ts-ignore and enables @typescript-eslint/ban-ts-ignore
  • Refactors code according to the upgraded version

divyanshiGupta avatar Jul 27 '22 16:07 divyanshiGupta

/cc @jerolimov /cc @invincibleJai

divyanshiGupta avatar Jul 27 '22 16:07 divyanshiGupta

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divyanshiGupta Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval by writing /assign @spadgett in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 27 '22 16:07 openshift-ci[bot]

/retest

divyanshiGupta avatar Jul 28 '22 08:07 divyanshiGupta

/retest

divyanshiGupta avatar Jul 28 '22 08:07 divyanshiGupta

/test kubevirt-plugin

invincibleJai avatar Aug 02 '22 06:08 invincibleJai

/retest

divyanshiGupta avatar Aug 04 '22 07:08 divyanshiGupta

@divyanshiGupta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/analyze 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test analyze
ci/prow/backend 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test backend
ci/prow/frontend 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test frontend
ci/prow/kubevirt-plugin 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test kubevirt-plugin
ci/prow/images 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test images
ci/prow/e2e-gcp-console 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test e2e-gcp-console
ci/prow/ceph-storage-plugin 3a989ffe4a29ac1123aeb8fdf234831bbc576211 link true /test ceph-storage-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 04 '22 09:08 openshift-ci[bot]

@divyanshiGupta: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Aug 27 '22 22:08 openshift-merge-robot