console
console copied to clipboard
openshift
Bug 2080260: Update OLM pages to use details and list page extensions for operands when they exist
- Update the CSV details page to load and render list and details page extensions for the operands it manages
- Remove container security route extensions that collide with olm create-operand routes
@TheRealJon: This pull request references Bugzilla bug 2080260, which is invalid:
- expected the bug to target the "4.12.0" release, but it targets "---" instead
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Bug 2080260: Update OLM pages to use details and list page extensions for operands when they exist
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jhadvig: This pull request references Bugzilla bug 2080260, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/bugzilla refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Remaining retests: 2 against base HEAD 33d235f217edb2f883606772a5b175ae36216d2d and 8 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 1 against base HEAD 33d235f217edb2f883606772a5b175ae36216d2d and 7 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 0 against base HEAD 33d235f217edb2f883606772a5b175ae36216d2d and 6 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 2 against base HEAD dd6fecf61e60efce7ada677f639f2136c2ecb650 and 5 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 1 against base HEAD dd6fecf61e60efce7ada677f639f2136c2ecb650 and 4 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 0 against base HEAD dd6fecf61e60efce7ada677f639f2136c2ecb650 and 3 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 2 against base HEAD 6c4aadd8ee3ad79722fb59d3cc63425758451a95 and 2 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 1 against base HEAD 6c4aadd8ee3ad79722fb59d3cc63425758451a95 and 1 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 0 against base HEAD 6c4aadd8ee3ad79722fb59d3cc63425758451a95 and 0 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/hold
Revision e8667e397f421734410c7657d880ae6750bccd77 was retested 9 times: holding
Failed Specs:
1) CRD extensions ConsoleExternalLogLink CRD : creates a new test pod to display the ConsoleExternalLogLink instance
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
at listOnTimeout internal/timers.js:554:17
at processTimers internal/timers.js:497:7
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
at listOnTimeout internal/timers.js:554:17
at processTimers internal/timers.js:497:7
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
at listOnTimeout internal/timers.js:554:17
at processTimers internal/timers.js:497:7
/retest
/hold cancel
Tests were failing due to a change outside this PR. See https://github.com/openshift/console/pull/11894
/retest-required
Remaining retests: 2 against base HEAD 55b670976787c601ec1d53ffa00f1bd8e0495f98 and 8 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 1 against base HEAD 55b670976787c601ec1d53ffa00f1bd8e0495f98 and 7 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 2 against base HEAD 029c38500a6be8d4dff15ec416e8865621735d03 and 6 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 1 against base HEAD 029c38500a6be8d4dff15ec416e8865621735d03 and 5 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 2 against base HEAD e27942a6c991b3fad97eca5e7b14a867b005d7cd and 4 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 2 against base HEAD a400c539dfec1317d18eff11812a9b145e28862a and 3 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 2 against base HEAD f5cb26ca8b6e9b4ed6c5d966d065f802fa9a0d5b and 2 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/retest-required
Remaining retests: 1 against base HEAD f5cb26ca8b6e9b4ed6c5d966d065f802fa9a0d5b and 1 for PR HEAD e8667e397f421734410c7657d880ae6750bccd77 in total
/hold
This is a legit CI failure. There's a RTE encountered during the global operator installation test.
/hold cancel
Found the issue and fixed it and also refactored my solution to simplify it a bit.
@TheRealJon the tests are failing with
frontend:
OperandDetailsPage › renders a `DetailsPage` with the correct subpages
Method “props” is meant to be run on 1 node. 0 found instead.
at ReactWrapper.single (node_modules/enzyme/src/ReactWrapper.js:1166:13)
at ReactWrapper.props (node_modules/enzyme/src/ReactWrapper.js:710:17)
at Object.<anonymous> (packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx:391:24)
at new Promise (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
● OperandDetailsPage › renders a `DetailsPage` which also watches the parent CSV
Method “props” is meant to be run on 1 node. 0 found instead.
at ReactWrapper.single (node_modules/enzyme/src/ReactWrapper.js:1166:13)
at ReactWrapper.props (node_modules/enzyme/src/ReactWrapper.js:710:17)
at ReactWrapper.prop (node_modules/enzyme/src/ReactWrapper.js:827:17)
at Object.<anonymous> (packages/operator-lifecycle-manager/src/components/operand/index.spec.tsx:400:38)
at new Promise (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
....
console:
2 failing
1) Globally installing "Service Binding Operator" operator in openshift-operators
Globally installs Service Binding Operator operator in openshift-operators and creates ServiceBinding operand:
AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-test="msg-box-title"]`, but never found it.
at Object.createOperand (https://console-openshift-console.apps.ci-op-q2hl16kt-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-install-global.spec.ts:14235:38)
at Context.eval (https://console-openshift-console.apps.ci-op-q2hl16kt-75d12.xxxxxxxxxxxxxxxxxxxxxx/__cypress/tests?p=tests/operator-install-global.spec.ts:14112:71)
2) Globally installing "Service Binding Operator" operator in openshift-operators
"after all" hook for "Globally installs Service Binding Operator operator in openshift-operators and creates ServiceBinding operand":
CypressError: You attempted to make a chai-jQuery assertion on an object that is neither a DOM object or a jQuery object.
...
TBH Im not sure what is causing the issue, since the code changes look good.