console icon indicating copy to clipboard operation
console copied to clipboard

CONSOLE-3179: Add deprecation note for react-helmet

Open zherman0 opened this issue 2 years ago • 20 comments

Adds deprecation note for react-helmet in the for dynamic plugins readme page.

This is only the first part to add a note saying it will be deprecated. There is no code change for this issue.

https://issues.redhat.com/browse/CONSOLE-3179

@vojtechszocs

zherman0 avatar Jul 25 '22 21:07 zherman0

/assign @vojtechszocs

zherman0 avatar Jul 25 '22 21:07 zherman0

@vojtechszocs - can you look at this to see if this is what we need?

zherman0 avatar Aug 04 '22 14:08 zherman0

QE Approver: /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @RickJWagner

Console Approver: /assign @vojtechszocs

jcaianirh avatar Aug 04 '22 21:08 jcaianirh

/label docs-approved

adellape avatar Aug 04 '22 23:08 adellape

/label px-approved

RickJWagner avatar Aug 05 '22 17:08 RickJWagner

no functional changes, just adding deprecation note /label qe-approved

yapei avatar Aug 08 '22 03:08 yapei

/lgtm

vojtechszocs avatar Aug 10 '22 13:08 vojtechszocs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vojtechszocs, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 10 '22 13:08 openshift-ci[bot]

/retest-required

Remaining retests: 2 against base HEAD 3610ecf3d59edebcbb0bec53f08251c272d8b5c4 and 8 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 10 '22 14:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD 50f3a15915d71b86ca2a8c39eef9e86f6b2ddcbb and 7 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 10 '22 23:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 50f3a15915d71b86ca2a8c39eef9e86f6b2ddcbb and 6 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 11 '22 01:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD 7ca267027d00e9ce218981eb5fe9310be34e6bec and 5 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 11 '22 03:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 7ca267027d00e9ce218981eb5fe9310be34e6bec and 4 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 11 '22 05:08 openshift-ci-robot

/retest

zherman0 avatar Aug 11 '22 22:08 zherman0

/retest-required

Remaining retests: 2 against base HEAD 64e232b527fd4c0e5ee2b0967493e4add6f6e872 and 3 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 12 '22 01:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 64e232b527fd4c0e5ee2b0967493e4add6f6e872 and 2 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 12 '22 03:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 64e232b527fd4c0e5ee2b0967493e4add6f6e872 and 1 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 12 '22 05:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD 30590e035e140acacc173881f6b2d004fa95ee57 and 0 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total

openshift-ci-robot avatar Aug 17 '22 19:08 openshift-ci-robot

/hold

Revision 344026961784e70fad755f4e8f2437a307df17c9 was retested 9 times: holding

openshift-ci-robot avatar Aug 18 '22 00:08 openshift-ci-robot

/hold cancel /retest

zherman0 avatar Aug 18 '22 18:08 zherman0

@zherman0: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 18 '22 23:08 openshift-ci[bot]