console
console copied to clipboard
CONSOLE-3179: Add deprecation note for react-helmet
Adds deprecation note for react-helmet in the for dynamic plugins readme page.
This is only the first part to add a note saying it will be deprecated. There is no code change for this issue.
https://issues.redhat.com/browse/CONSOLE-3179
@vojtechszocs
/assign @vojtechszocs
@vojtechszocs - can you look at this to see if this is what we need?
QE Approver: /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @RickJWagner
Console Approver: /assign @vojtechszocs
/label docs-approved
/label px-approved
no functional changes, just adding deprecation note /label qe-approved
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vojtechszocs, zherman0
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/console-dynamic-plugin-sdk/OWNERS~~ [vojtechszocs]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/retest-required
Remaining retests: 2 against base HEAD 3610ecf3d59edebcbb0bec53f08251c272d8b5c4 and 8 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 2 against base HEAD 50f3a15915d71b86ca2a8c39eef9e86f6b2ddcbb and 7 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 1 against base HEAD 50f3a15915d71b86ca2a8c39eef9e86f6b2ddcbb and 6 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 2 against base HEAD 7ca267027d00e9ce218981eb5fe9310be34e6bec and 5 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 1 against base HEAD 7ca267027d00e9ce218981eb5fe9310be34e6bec and 4 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest
/retest-required
Remaining retests: 2 against base HEAD 64e232b527fd4c0e5ee2b0967493e4add6f6e872 and 3 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 1 against base HEAD 64e232b527fd4c0e5ee2b0967493e4add6f6e872 and 2 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 0 against base HEAD 64e232b527fd4c0e5ee2b0967493e4add6f6e872 and 1 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/retest-required
Remaining retests: 2 against base HEAD 30590e035e140acacc173881f6b2d004fa95ee57 and 0 for PR HEAD 344026961784e70fad755f4e8f2437a307df17c9 in total
/hold
Revision 344026961784e70fad755f4e8f2437a307df17c9 was retested 9 times: holding
/hold cancel /retest
@zherman0: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.