console icon indicating copy to clipboard operation
console copied to clipboard

Bug 1993916: Consider cases where disabled menu is not due to deletion

Open rexagod opened this issue 3 years ago • 17 comments

Consider cases where disabled menu is not due to deletion of the resource for the feedback logic.

Signed-off-by: Pranshu Srivastava [email protected]

rexagod avatar Jul 21 '22 13:07 rexagod

@rexagod: This pull request references Bugzilla bug 2102337, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2102337: Consider cases where disabled menu is not due to deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 21 '22 13:07 openshift-ci[bot]

/bugzilla refresh

rexagod avatar Jul 21 '22 14:07 rexagod

@rexagod: This pull request references Bugzilla bug 2102337, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "ODF 4.12.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 21 '22 14:07 openshift-ci[bot]

Test failures are not related to this PR, it seems.

rexagod avatar Aug 02 '22 07:08 rexagod

/test ceph-storage-plugin

rexagod avatar Aug 10 '22 07:08 rexagod

/hold

  -  /go/src/github.com/openshift/console/frontend/gui_test_screenshots/cypress/scree     (1280x720)
     nshots/multiple-storageclass-selection.spec.ts/Add capacity using multiple stora               
     ge classes -- Add capacity with a new storage class having EBS as provisioner (f               
     ailed).png   

Looks like a legit error @rexagod.

jhadvig avatar Aug 10 '22 12:08 jhadvig

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Aug 10 '22 17:08 openshift-ci[bot]

More context and recording: https://github.com/red-hat-storage/odf-console/pull/371#issue-1335499361.

rexagod avatar Aug 11 '22 06:08 rexagod

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 18 '22 13:08 openshift-ci[bot]

/test e2e-gcp-console

rexagod avatar Sep 27 '22 06:09 rexagod

/bugzilla refresh

rexagod avatar Oct 17 '22 13:10 rexagod

@rexagod: This pull request references Bugzilla bug 1993916, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1993916: Consider cases where disabled menu is not due to deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 17 '22 13:10 openshift-ci[bot]

@rexagod: This pull request references Bugzilla bug 1993916, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 17 '22 13:10 openshift-ci[bot]

/bugzilla refresh

rexagod avatar Oct 17 '22 13:10 rexagod

@rexagod: This pull request references Bugzilla bug 1993916, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @mashetty330

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 17 '22 13:10 openshift-ci[bot]

/retest

rexagod avatar Oct 17 '22 14:10 rexagod

In the visuals below you may notice the ODF Console was being served as well, but I have verified the exact same behavior after disabling that and serving just ceph-storage-plugin (except for blockpools, since they weren't accessible without ODF). All ODF-only resources will be addressed in https://github.com/red-hat-storage/odf-console/pull/371.

OBCs

Screencast from 2022-10-19 00-04-30.webm

PVCs

Screencast from 2022-10-19 00-03-14.webm

BlockPools

Screencast from 2022-10-18 23-58-50.webm

StorageSystems

Screencast from 2022-10-19 00-09-04.webm


This was tested on 4.10 OCP with 4.10 ODF, since later ODF installs had failing OCS CSV, which disabled me to test out this PR in its entirety. Same thing happened for 4.12.

Details

Screenshot from 2022-10-18 22-51-29 Screenshot from 2022-10-18 22-51-18 Screenshot from 2022-10-18 21-41-46

rexagod avatar Oct 18 '22 18:10 rexagod

/retest

rexagod avatar Oct 19 '22 05:10 rexagod

/test images

rexagod avatar Oct 19 '22 14:10 rexagod

@rexagod: This pull request references Bugzilla bug 1993916, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @mashetty330

In response to this:

Bug 1993916: Consider cases where disabled menu is not due to deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 20 '22 10:10 openshift-ci[bot]

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 21 '22 16:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, jhadvig, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 07 '22 04:11 openshift-ci[bot]

@rexagod: All pull requests linked via external trackers have merged:

Bugzilla bug 1993916 has been moved to the MODIFIED state.

In response to this:

Bug 1993916: Show tooltips for contextual information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 07 '22 08:11 openshift-ci[bot]

/cherry-pick release-4.12

rexagod avatar Nov 08 '22 11:11 rexagod

@rexagod: new pull request created: #12252

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.