console icon indicating copy to clipboard operation
console copied to clipboard

ODC-6712 & ODC-6714: Add a build decorator for Shipwright Builds and builds section into topology sidebar for Shipwright Builds and BuildRuns

Open Lucifergene opened this issue 3 years ago • 11 comments

Fixes:

Solution Description:

  1. Added a Decorator to the Shipwright-build-controller Deployment that would provide the status of the latest Build Run.
  2. When a user clicks on the decorator, they would be navigated to the BuildRun logs page.
  3. Added BuildRun section to the existing Topology Sidebar below the Pods Section, which lists all the Shipwright Builds.
  4. Clicking on the Build Names redirects the user to the corresponding Builds Page.
  5. If there are Buildruns corresponding to a build, they are listed below the corresponding Build along with the View Logs link that takes the user to the logs of the corresponding BuildRun.
  6. The user is also given the facility to Start a Build from the Sidebar by clicking the Start Build button. If there are preexisting buildRuns to a Build, then the user is given the facility to re-run the latest BuildRun.

Screen shots / Gifs for design review:

ODC-6712: Add a build decorator for Shipwright Builds (latest BuildRun) in topology graph

https://user-images.githubusercontent.com/47265560/181737247-43250389-c700-415c-895f-d19ad017234c.mp4


ODC-6714: Add builds section into topology sidebar (details tab) for Shipwright Builds and BuildRuns

https://user-images.githubusercontent.com/47265560/181735055-76eb89d1-b5c2-473a-a56b-8b7bff4083ad.mp4

E2E test coverage report:

e2e-results

e2e-test-dec-side

Test setup:

  1. Install the Shipwright operator along with the OC pipelines operator.
  2. Create a Shipwright Build instance.
  3. Navigate to the samples folder in the shipwright-plugin package and use the oc create -f . to install the resources in the namespace.
  4. Come to the Topology page in the build-examples namespace.
  5. Here, you will see various deployments/configs/k-servings created and will also the status of the BuildRun from the decorator attached to each of the resources.
  6. Click on each of the deployments/configs/k-servings to see the Topology Sidebar. You can see the new BuildRuns section below the Pods Section.
  7. You can Start a new BuildRun or run the latest BuildRun from there.

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge

Lucifergene avatar Jul 19 '22 18:07 Lucifergene

/assign @jerolimov

Lucifergene avatar Jul 19 '22 19:07 Lucifergene

/retest-required

Lucifergene avatar Jul 20 '22 06:07 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Jul 28 '22 16:07 Lucifergene

/label docs-approved /label px-approved

Lucifergene avatar Aug 04 '22 08:08 Lucifergene

Tested the pr using cluster-bot, build decorator was not showing for deployment and deployment-config

sanketpathak avatar Aug 04 '22 12:08 sanketpathak

/retest

christoph-jerolimov avatar Aug 10 '22 08:08 christoph-jerolimov

@sanketpathak The issue is fixed. Also, E2E tests are added. PTAL.

Lucifergene avatar Aug 12 '22 00:08 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Aug 13 '22 09:08 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Aug 18 '22 07:08 Lucifergene

The latest buildrun should be listed first

Screenshot 2022-08-23 at 12 54 33 PM

debsmita1 avatar Aug 23 '22 07:08 debsmita1

should there be 2 view all links ?

Screenshot 2022-08-23 at 1 28 08 PM

debsmita1 avatar Aug 23 '22 07:08 debsmita1

Tested on cluster-bot, works fine Screenshot from 2022-08-23 23-00-37

/label qe-approved

sanketpathak avatar Aug 23 '22 17:08 sanketpathak

/lgtm

debsmita1 avatar Aug 23 '22 17:08 debsmita1

/test e2e-gcp-console

invincibleJai avatar Aug 24 '22 05:08 invincibleJai

/assign

invincibleJai avatar Aug 24 '22 05:08 invincibleJai

/lgtm /approve

Thanks @Lucifergene

invincibleJai avatar Aug 24 '22 09:08 invincibleJai

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, invincibleJai, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 24 '22 09:08 openshift-ci[bot]

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 24 '22 12:08 openshift-ci[bot]