console icon indicating copy to clipboard operation
console copied to clipboard

Bug 2041389: Fix explore-type-sidebar path resolving

Open raspbeep opened this issue 3 years ago • 9 comments
trafficstars

Fixes path resolving in YAML sidebar navigation.

The issue was, that references($ref) in k8s/openapi was not followed. The created path looked like: io.k8s.api.apps.v1.Deployment, properties, spec, properties, selector, ... instead of being correctly resolved on the way: io.k8s.api.apps.v1.DeploymentSpec, properties, selector, ....

Signed-off-by: Pavel Kratochvil [email protected]

raspbeep avatar Jul 07 '22 13:07 raspbeep

@raspbeep: This pull request references Bugzilla bug 2041389, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

Bug 2041389: Fix explore-type-sidebar path resolving

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 07 '22 13:07 openshift-ci[bot]

Hi @raspbeep. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 07 '22 13:07 openshift-ci[bot]

/ok-to-test

spadgett avatar Jul 07 '22 13:07 spadgett

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raspbeep, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 07 '22 13:07 openshift-ci[bot]

/hold

raspbeep avatar Jul 07 '22 15:07 raspbeep

/test e2e-gcp-console

jhadvig avatar Jul 07 '22 17:07 jhadvig

/test e2e-gcp-console

jhadvig avatar Jul 08 '22 07:07 jhadvig

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Jul 10 '22 07:07 openshift-ci[bot]

@raspbeep: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend d85236cff6144c0dd99cb8062feb0818f005f208 link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 21 '22 12:07 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Oct 20 '22 01:10 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Nov 19 '22 08:11 openshift-bot