Bug 2100489: updated various modal layout

[mattnolting]

closes https://bugzilla.redhat.com/show_bug.cgi?id=2100489

Updated delete modal

Before

After

Went through the modals, updated the those with either inconsistent markup and/or visual mistakes.

in console/frontend/public/components/modals/

add-secret-to-workload.tsx

Before

After

add-users-modal.tsx - couldn’t initiate, code looks good alert-routing-modal.tsx - couldn’t initiate, code looks good cluster-channel-modal.tsx - previewed, looks good cluster-more-updates-modal.tsx - couldn’t initiate, code looks good cluster-update-modal.tsx - previewed, looks good

column-management-modal.tsx

Before

After

configure-cluster-upstream-modal.jsx

Before

After

configure-count-modal.tsx

Before

After

create-machinę-autoscaler-modal.tsx - couldn’t initiate, code looks ok configure-ns-pull-secret-modal.jsx - couldn’t initiate confirm-modal.jsx - code looks good delete-pvc-modal.tsx - previewed, code looks good error-modal.tsx - couldn’t initiate, code looks ok

expand-pvc-modal.tsx

Before

After

Labels-modal.jsx

Before

After

managed-resource-save-modal.tsx - couldn’t initiate, code looks ok remove-user-modal.tsx - couldn’t initiate, code looks ok remove-volume-modal.tsx - couldn’t initiate, code looks good rollback-modal.jsx - couldn’t initiate, code looks bad tags.tsx - couldn’t initiate, code looks good taints-modal.tsx - couldn’t initiate, code looks fine tolertations-modal.tsx - couldn’t initiate, code looks fine

followup to

[openshift-ci[bot]]

Hi @mattnolting. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci[bot]]

@mattnolting: This pull request references Bugzilla bug 2100489, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2100489: updated various modal layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/bugzilla refresh

/ok-to-test

[openshift-ci[bot]]

@rhamilto: This pull request references Bugzilla bug 2100489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/bugzilla refresh

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattnolting, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

@mattnolting: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	2c20fe82bcd864bd46a8fd02d6baf4df35d2bf4f	link	true	/test e2e-gcp-console
ci/prow/frontend	2c20fe82bcd864bd46a8fd02d6baf4df35d2bf4f	link	true	/test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

@mattnolting: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

[rhamilto]

@sg00dwin, do you know if these changes were accounted for elsewhere? If not, it would still be good to get these in.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci[bot]]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci[bot]]

@mattnolting: This pull request references Bugzilla bug 2100489. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. Warning: Failed to comment on Bugzilla bug with reason for changed state.

In response to this:

Bug 2100489: updated various modal layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.