console
console copied to clipboard
openshift
Bug 2100860: Use Alertmanager services for user-defined alerts from config
https://issues.redhat.com/browse/MON-2289
Requires https://github.com/openshift/cluster-monitoring-operator/pull/1690 Requires https://github.com/openshift/console-operator/pull/658
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't see any problems with the general approach and generally LGTM.
I'd like to get someone more familiar with the backend code to review that.
@simonpasquier: This pull request references Bugzilla bug 2100860, which is invalid:
- expected the bug to target the "4.12.0" release, but it targets "---" instead
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Bug 2100860: Use Alertmanager services for user-defined alerts from config
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@simonpasquier: This pull request references Bugzilla bug 2100860, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @juzhao
In response to this:
/bugzilla refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@simonpasquier: This pull request references Bugzilla bug 2100860, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @juzhao
In response to this:
/bugzilla refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@simonpasquier I think we just need to squash the commits, otherwise LGTM.
@jhadvig Could you please take another look?
@jhadvig can you give it a review please? https://github.com/openshift/console-operator/pull/658 has merged now and https://github.com/openshift/cluster-monitoring-operator/pull/1690 should follow soon too.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cmd/OWNERS~~ [jhadvig]
- ~~frontend/OWNERS~~ [jhadvig]
- ~~pkg/OWNERS~~ [jhadvig]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD dd96b2f07b7e281f4d2798d3e8dfa84ae4a51298 and 2 for PR HEAD 73168e88b2e4fb05d34e0e03516a263c42ac206a in total
/retest-required
Remaining retests: 0 against base HEAD f728e3113298230d4cfd7a347c7c75a07c9d369f and 1 for PR HEAD 73168e88b2e4fb05d34e0e03516a263c42ac206a in total
/retest-required
Remaining retests: 0 against base HEAD d216f9985b72cf54f9c5d17257637c138db57610 and 0 for PR HEAD 73168e88b2e4fb05d34e0e03516a263c42ac206a in total
@simonpasquier: All pull requests linked via external trackers have merged:
Bugzilla bug 2100860 has been moved to the MODIFIED state.
In response to this:
Bug 2100860: Use Alertmanager services for user-defined alerts from config
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@simonpasquier: new pull request created: #12104
In response to this:
/cherrypick release-4.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
