console
console copied to clipboard
openshift
Bug 2096374: Improve SLA stability by not fetching the subscription twice at the same time
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2096374
Analysis / Root cause: SLA was fetched two times at the same time. This might confuse our e2e tests. The UI is flickering.
Solution Description:
Fetch subscription only when useGetServiceLevel was called from useShowServiceLevelNotifications. useShowServiceLevelNotifications was used in the ConnectedNotificationDrawer, which was always rendered in app.jsx.
So it is not needed to call the API again from the components ServiceLevelNotification and ServiceLevelText.
Screenrecording:
SLA API calls before:
https://user-images.githubusercontent.com/139310/175275581-2de30d67-08ce-4175-8c2b-4a9784cceeb8.mp4
SLA API calls with this PR:
https://user-images.githubusercontent.com/139310/175298429-a605416f-ec56-4a46-b143-dc51ac5915e5.mp4
Hmmm, got a 403, but that's not related to this error. Does PR based clusters doesn't have a valid SLA? :thinking:
Unit test coverage report: Untouched
Test setup:
- Open the network inspector and filter for
api/accounts_mgmt - Reload the console
- Check that the information from the SLA are still displayed correctly
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
@jerolimov: GitHub didn't allow me to request PR reviews from the following users: yet.
Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc none yet
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jerolimov
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [jerolimov]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jerolimov: This pull request references Bugzilla bug 2096374, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.11.0) matches configured target release for branch (4.11.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Bug 2096374: Improve SLA test stability by not fetching subscription two times (at the same time)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jerolimov: This pull request references Bugzilla bug 2096374, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.11.0) matches configured target release for branch (4.11.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Bug 2096374: Improve SLA test stability by not fetching subscription two times (at the same time)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jerolimov: This pull request references Bugzilla bug 2096374, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.11.0) matches configured target release for branch (4.11.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Bug 2096374: Improve SLA test stability by not fetching subscription two times (at the same time)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jerolimov: An error was encountered querying GitHub for users with public email ([email protected]) for bug 2096374 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.
Full error message.
Post "http://ghproxy/graphql": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.
In response to this:
Bug 2096374: Improve SLA test stability by not fetching subscription two times (at the same time)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jerolimov: This pull request references Bugzilla bug 2096374, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.11.0) matches configured target release for branch (4.11.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Bug 2096374: Improve SLA test stability by not fetching subscription two times (at the same time)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jerolimov: This pull request references Bugzilla bug 2096374, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.11.0) matches configured target release for branch (4.11.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Bug 2096374: Improve SLA test stability by not fetching subscription two times (at the same time)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jerolimov: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jerolimov: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.