console
console copied to clipboard
CONSOLE-3179: Improve control over shared modules provided by Console to dynamic plugins
Fixes CONSOLE-3179
All shared modules provided by Console to its dynamic plugins currently have the same configuration:
singleton: truemeans there can be only a single version of the module loaded at runtimeimport: falsemeans plugins will not attempt to bring their own fallback version of the module
This PR allows for better control over shared modules via the sharedPluginModulesMetadata object.
Additionally, react-helmet module metadata has been updated to { singleton: false, allowFallback: true }.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: spadgett, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/console-dynamic-plugin-sdk/OWNERS~~ [spadgett,vojtechszocs]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
CI Failure. Not sure I've seen this one "Cypress verification timed out.":
$ cd packages/integration-tests-cypress && node --max-old-space-size=4096 ../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome}
It looks like this is your first time using Cypress: 8.5.0
[STARTED] Task without title.
[FAILED] Cypress verification timed out.
[FAILED]
[FAILED] This command failed with the following output:
[FAILED]
[FAILED] /opt/home/.cache/Cypress/8.5.0/Cypress/Cypress --no-sandbox --smoke-test --ping=398
[FAILED]
[FAILED] ----------
[FAILED]
[FAILED] Fontconfig warning: "/etc/fonts/fonts.conf", line 100: unknown element "blank"
[FAILED]
[FAILED] ----------
[FAILED]
[FAILED] Platform: linux (Debian - 9.13)
[FAILED] Cypress Version: 8.5.0
Cypress verification timed out.
This command failed with the following output:
/opt/home/.cache/Cypress/8.5.0/Cypress/Cypress --no-sandbox --smoke-test --ping=398
----------
Fontconfig warning: "/etc/fonts/fonts.conf", line 100: unknown element "blank"
----------
Platform: linux (Debian - 9.13)
Cypress Version: 8.5.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run v1.22.15
/retest
QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner
/label docs-approved
tested the PR and verified it is working /label qe-approved
/label px-approved
@vojtechszocs: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.