Bug 2076619: Modified git import flow module to handle create button enable-disable issue

[lokanandaprabhu]

Fixes: https://issues.redhat.com/browse/OCPBUGSM-43404

Analysis / Root cause:

1. Build starategy was not update when builder image is selected by default, so the create button was not getting enabled.
2. No separate message when devfile is not detected for Git type - other
3. On change of import strategy error message was not cleared.

Solution Description:

1. Updated Build starategy to 'Source'.
2. Disabled Devfile import strategy for Git type - other
3. On change of import strategy calling a method which will handle the error showing part.

Screen shots / Gifs for design review:

https://user-images.githubusercontent.com/102503482/191943839-30293edb-8866-4867-80ae-3e1b358689fa.mov

Unit test coverage report: NA

Test setup: CASE A

1. Switch to developer perspective, add page > import from Git
2. Enter URL https://mysupersecretgit.example.com/org/repo
3. Select Builder image (node.js for example), enter a name. Now all required fields are filled.

CASE B

1. Switch to developer perspective, add page > import from Git
2. Enter URL https://mysupersecretgit.example.com/org/repo
3. Select Devfile, enter "Devfile", a name. Now all required fields are filled.

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

[openshift-ci[bot]]

@lokanandaprabhu: This pull request references Bugzilla bug 2076619, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

Bug 2076619: Modified git import flow module to handle create button enable-disable issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/cc @abhinandan13jan

[abhinandan13jan]

tested locally, works as expected... but I see that revalidation isn't working properly. Not sure whether it is related. cc: @jerolimov

For devfile flow

For github flow

[abhinandan13jan]

tested again!! the issue around revalidation still exists

[lokanandaprabhu]

tested again!! the issue around revalidation still exists

I also tested this. My observation is, it is like this in 4.11 (Master) and 4.10 versions also. If URL gets validated successfully (consider for github) it is revalidating for onChange event.

I will wait for @jerolimov response on this.

cc: @jerolimov

[christoph-jerolimov]

/cc /assign

[lokanandaprabhu]

/retest

[lokanandaprabhu]

/test e2e-gcp-console

[christoph-jerolimov]

Hey @lokanandaprabhu , do get this please address the following issues:

1. Rebase this PR
2. Address Jais two review comments (add a type for devfileStrategyInput and use data-test instead of data-test-id) https://github.com/openshift/console/pull/11493#pullrequestreview-1028203535
3. Check with Serena the wording of "Could not get Devfile for an unknown Git type"

When the user selects a strategy and changes the URL (the comment from Abhi) the Import strategy always jumps to Builder Image is IMO not related to this PR. This happens also for GitHub URLs. We could improve this case, but we can address this edge case another time.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lokanandaprabhu Once this PR has been reviewed and has the lgtm label, please ask for approval from jerolimov by writing /assign @jerolimov in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[lokanandaprabhu]

Hi @jerolimov ,

I attached the screenshot, if the git type is Other, then Devfile has to be disabled with a tooltip. Just for taking screenshot I added some text there, I can change that. This design is fine or any feedback on this? If this is fine, I will start to work on this.

[lokanandaprabhu]

Hi @jerolimov ,

Can you take a look at the comment - https://github.com/openshift/console/pull/11493#issuecomment-1208005946 and provide your feedback.

Thanks.

[openshift-ci[bot]]

@lokanandaprabhu: This pull request references Bugzilla bug 2076619, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

Bug 2076619: Modified git import flow module to handle create button enable-disable issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lokanandaprabhu]

/retest

[lokanandaprabhu]

/retest

[openshift-ci[bot]]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lokanandaprabhu]

Hi @jerolimov ,

Requesting your review on this.