console
console copied to clipboard
Add basic support for Modals
- Adds a Provider to inject ModalComponent and associated props for the Modal at the top of the tree.
- Exposes a
useModal
hook which supplies users withlaunchModal
function that accepts a function returning JSX component. - Exposes a
AsyncLoader
component which allows users to asynchronously load Modal related modules. -
a/sync
loading behaviour is configurable by user. - Updates OLM Operand tables/Details Page to use
LazyActionMenu
- Updates demo-plugin toadd Modal example code.
Recording:
https://user-images.githubusercontent.com/54092533/180926314-49bdb907-3f7b-42be-8913-a4ba4a4fa1a3.mp4
/cc @christianvogt @andrewballantyne
@bipuladh: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
OLM pages Actions menu
/retest
/retest
/retest
/retest
/retest
/approve @vojtechszocs could you also have a look
/retest
/retest
/lgtm
/test e2e-gcp-console
/retest
/test e2e-gcp-console
/retest
it looks like All instances
list is re-rendered every several seconds, didn't reproduce the issue on a normal OCP cluster without this PR changes so I guess it probably a regression caused by this PR
https://user-images.githubusercontent.com/12692381/185363124-4708dfa1-6834-4c38-9bcc-ce169785d0c9.mov
the above issue is not reproduced in latest testing, no issues found /label qe-approved
/label px-approved
/test ceph-storage-plugin
/label docs-approved
/retest
/retest-required
Remaining retests: 2 against base HEAD 50fb27994b907cea13d3f25b65b2131849e4ed14 and 8 for PR HEAD b6e639061b540b872aab9c154465eb47987c34be in total
/test frontend
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bipuladh, christianvogt, jhadvig, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~dynamic-demo-plugin/OWNERS~~ [christianvogt,jhadvig,vojtechszocs]
- ~~frontend/OWNERS~~ [christianvogt,jhadvig,vojtechszocs]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/retest-required
Remaining retests: 2 against base HEAD f9016b9c9c28d47290b2a9c927a87a590e647a63 and 8 for PR HEAD e50415328b8bbd08c13c5a1a7d26cc011c21b8c9 in total
/retest-required
Remaining retests: 1 against base HEAD f9016b9c9c28d47290b2a9c927a87a590e647a63 and 7 for PR HEAD e50415328b8bbd08c13c5a1a7d26cc011c21b8c9 in total
/retest-required
Remaining retests: 0 against base HEAD f9016b9c9c28d47290b2a9c927a87a590e647a63 and 6 for PR HEAD e50415328b8bbd08c13c5a1a7d26cc011c21b8c9 in total