console icon indicating copy to clipboard operation
console copied to clipboard

Add basic support for Modals

Open bipuladh opened this issue 2 years ago • 19 comments

  • Adds a Provider to inject ModalComponent and associated props for the Modal at the top of the tree.
  • Exposes a useModal hook which supplies users with launchModal function that accepts a function returning JSX component.
  • Exposes a AsyncLoader component which allows users to asynchronously load Modal related modules.
  • a/sync loading behaviour is configurable by user.
  • Updates OLM Operand tables/Details Page to use LazyActionMenu
  • Updates demo-plugin toadd Modal example code.

Recording:

https://user-images.githubusercontent.com/54092533/180926314-49bdb907-3f7b-42be-8913-a4ba4a4fa1a3.mp4

bipuladh avatar Mar 09 '22 10:03 bipuladh

/cc @christianvogt @andrewballantyne

spadgett avatar Mar 09 '22 15:03 spadgett

@bipuladh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 09 '22 22:04 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jul 09 '22 01:07 openshift-bot

OLM pages Actions menu

Screenshot from 2022-07-26 14-42-38 Screenshot from 2022-07-26 14-42-27

bipuladh avatar Jul 26 '22 08:07 bipuladh

/retest

bipuladh avatar Jul 26 '22 14:07 bipuladh

/retest

bipuladh avatar Jul 27 '22 04:07 bipuladh

/retest

bipuladh avatar Jul 27 '22 06:07 bipuladh

/retest

bipuladh avatar Jul 27 '22 07:07 bipuladh

/retest

bipuladh avatar Jul 29 '22 08:07 bipuladh

/approve @vojtechszocs could you also have a look

christianvogt avatar Aug 02 '22 15:08 christianvogt

/retest

bipuladh avatar Aug 11 '22 09:08 bipuladh

/retest

bipuladh avatar Aug 11 '22 14:08 bipuladh

/lgtm

vojtechszocs avatar Aug 11 '22 15:08 vojtechszocs

/test e2e-gcp-console

bipuladh avatar Aug 12 '22 03:08 bipuladh

/retest

bipuladh avatar Aug 14 '22 01:08 bipuladh

/test e2e-gcp-console

bipuladh avatar Aug 16 '22 03:08 bipuladh

/retest

bipuladh avatar Aug 18 '22 01:08 bipuladh

it looks like All instances list is re-rendered every several seconds, didn't reproduce the issue on a normal OCP cluster without this PR changes so I guess it probably a regression caused by this PR

https://user-images.githubusercontent.com/12692381/185363124-4708dfa1-6834-4c38-9bcc-ce169785d0c9.mov

yapei avatar Aug 18 '22 09:08 yapei

the above issue is not reproduced in latest testing, no issues found /label qe-approved

yapei avatar Aug 22 '22 10:08 yapei

/label px-approved

RickJWagner avatar Aug 22 '22 13:08 RickJWagner

/test ceph-storage-plugin

bipuladh avatar Aug 22 '22 13:08 bipuladh

/label docs-approved

opayne1 avatar Aug 22 '22 13:08 opayne1

/retest

bipuladh avatar Aug 22 '22 15:08 bipuladh

/retest-required

Remaining retests: 2 against base HEAD 50fb27994b907cea13d3f25b65b2131849e4ed14 and 8 for PR HEAD b6e639061b540b872aab9c154465eb47987c34be in total

openshift-ci-robot avatar Aug 22 '22 23:08 openshift-ci-robot

/test frontend

bipuladh avatar Aug 23 '22 06:08 bipuladh

/lgtm

jhadvig avatar Aug 23 '22 09:08 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, christianvogt, jhadvig, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 23 '22 09:08 openshift-ci[bot]

/retest-required

Remaining retests: 2 against base HEAD f9016b9c9c28d47290b2a9c927a87a590e647a63 and 8 for PR HEAD e50415328b8bbd08c13c5a1a7d26cc011c21b8c9 in total

openshift-ci-robot avatar Aug 23 '22 11:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD f9016b9c9c28d47290b2a9c927a87a590e647a63 and 7 for PR HEAD e50415328b8bbd08c13c5a1a7d26cc011c21b8c9 in total

openshift-ci-robot avatar Aug 23 '22 12:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f9016b9c9c28d47290b2a9c927a87a590e647a63 and 6 for PR HEAD e50415328b8bbd08c13c5a1a7d26cc011c21b8c9 in total

openshift-ci-robot avatar Aug 23 '22 13:08 openshift-ci-robot