openshift
Bug 2034551: Fix name filter updates when input is cleared
There was a too defensive check for false-y values. But these false-y values are still valid so removing the check fixes the issue.
@rawagner: This pull request references Bugzilla bug 2034551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.10.0) matches configured target release for branch (4.10.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Bug 2034551: Fix name filter updates when input is cleared
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/bugzilla refresh
The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.
@openshift-bot: This pull request references Bugzilla bug 2034551, which is invalid:
- expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/bugzilla refresh
The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@rhamilto: This pull request references Bugzilla bug 2034551, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.11.0) matches configured target release for branch (4.11.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/bugzilla refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The changes here break filtering by query string param on load of the page. For example, http://localhost:9000/k8s/cluster/customresourcedefinitions?name=ConsoleCLIDownload does not load the list with the filter applied. This is what is causing the failing integration test.
/hold