cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

Published 20 hours ago • verified publisher icon openshift

LOG-5474: Fix CLO rotate_wait_ms to rotate_wait_secs

Open Clee2691 opened this issue 9 months ago • 5 comments

Description

This PR fixes rotate_wait_ms to rotate_wait_secs as this was implemented in upstream vector:0.37.0. This also changes CLO to use vector:6.0 in the deployment patch & functional benchmarker.

/cc @cahartma @vparfonov /assign @jcantrill

Links

  • JIRA: https://issues.redhat.com/browse/LOG-5474

Clee2691 avatar Apr 30 '24 21:04 Clee2691

@Clee2691: This pull request references LOG-5474 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR fixes rotate_wait_ms to rotate_wait_secs as this was implemented in upstream vector:0.37.0. This also changes CLO to use vector:6.0 in the deployment patch & functional benchmarker.

/cc @cahartma @vparfonov /assign @jcantrill

Links

  • JIRA: https://issues.redhat.com/browse/LOG-5474

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 30 '24 21:04 openshift-ci-robot

@Clee2691: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional-target edd3884ff4e861e8e7b95d4ab83600fe65569a69 link true /test functional-target
ci/prow/e2e-target edd3884ff4e861e8e7b95d4ab83600fe65569a69 link true /test e2e-target

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 01 '24 00:05 openshift-ci[bot]

Blocked by https://github.com/openshift/release/pull/51542

jcantrill avatar May 01 '24 14:05 jcantrill

/approve

jcantrill avatar May 01 '24 14:05 jcantrill

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 01 '24 14:05 openshift-ci[bot]