cluster-logging-operator
cluster-logging-operator copied to clipboard
openshift
LOG-5322 & LOG-5323 segfaults if PrunfilterSpec or DropTestsSpec not spec'd
Description
This PR adds a nil check for drop and prune filters during validation and will raise a validation error if the appropriate FilterTypeSpec is not defined.
/cc @cahartma @vparfonov /assign @jcantrill
Links
- JIRA:
- https://issues.redhat.com/browse/LOG-5322
- https://issues.redhat.com/browse/LOG-5323
@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you.
In response to this:
/cherrypick release-5.9
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Clee2691, jcantrill
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jcantrill]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD 5b4f827bc1ee4aa692f5d4ea35e23eb6d10e159f and 2 for PR HEAD 949fc46a639ae8d12c6568cc1dea9a7137664bb7 in total
@Clee2691: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jcantrill: new pull request created: #2434
In response to this:
/cherrypick release-5.9
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.