cluster-logging-operator
cluster-logging-operator copied to clipboard
openshift
LOG-4910: remove collector daemonset only if 'Not authorized to collect' error occurs
Description
This PR addresses the behavior of the reconciliation process, specifically focusing on error handling: the reconciler should skip all errors and leave the collector instance unchanged, only removing it in the event of a Not authorized to collect error.
/cc @Clee2691 @cahartma /assign @jcantrill
/cherry-pick
Links
- Depending on PR(s):
- Bugzilla:
- Github issue:
- JIRA: https://issues.redhat.com/browse/LOG-4910
- Enhancement proposal:
@vparfonov: This pull request references LOG-4910 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.
In response to this:
Description
This PR addresses the behavior of the reconciliation process, specifically focusing on error handling: the reconciler should skip all errors and leave the collector instance unchanged, only removing it in the event of a
Not authorized to collecterror./cc @Clee2691 @cahartma /assign @jcantrill
/cherry-pick
Links
- Depending on PR(s):
- Bugzilla:
- Github issue:
- JIRA: https://issues.redhat.com/browse/LOG-4910
- Enhancement proposal:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcantrill, vparfonov
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jcantrill]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you.
In response to this:
/cherrypick release-5.9
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-ocp-target-minus-one
In response to this:
/override ci/prow/e2e-ocp-target-minus-one
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-ocp-target-minus-two
In response to this:
/override ci/prow/e2e-ocp-target-minus-two
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Remaining retests: 0 against base HEAD 0e262a48494d46b6a69865d799e3c1fe1f805665 and 2 for PR HEAD f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 in total
/retest-required
Remaining retests: 0 against base HEAD 085bdc1fd735d430a59a1ae92e24f18284c6e956 and 1 for PR HEAD f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 in total
/retest-required
Remaining retests: 0 against base HEAD 9c19c9baff4ddc56f47e3ba1b39effa782ed37aa and 0 for PR HEAD f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 in total
/hold
Revision f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 was retested 3 times: holding
@vparfonov: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you.
In response to this:
/cherry-pick release-5.9
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Remaining retests: 0 against base HEAD 83904d97f9283892f5338aa4a67a0bfc2f7d2f39 and 2 for PR HEAD f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 in total
/retest-required
Remaining retests: 0 against base HEAD 22146ec3b33a2171456c09042c78ce695b12ec3f and 1 for PR HEAD f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 in total
/retest-required
Remaining retests: 0 against base HEAD 6dd75c6b1b7b6e1215c8f567af14690f62091088 and 0 for PR HEAD f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 in total
/hold
Revision f9cf073ad7c4c1df2145b65c4b6b1dccb6869fc0 was retested 3 times: holding