cluster-logging-operator
cluster-logging-operator copied to clipboard
openshift
LOG-5298: Refactor Viaq model to be a filter
Description
This PR:
- refactors the viaq data model to be a filter so that it is easier to swap out
- Moves all RH/viaq specific changes to the viaq filter
- Adds log_type, log_source to the source so we can make decisions in transforms
- Allows the ability to split some viaq transforms into configurable filters (e.g. loglevel, journal debug level, etc)
- blocked on #2463
Links
https://issues.redhat.com/browse/LOG-5298
/hold
@jcantrill: This pull request references LOG-5298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.
In response to this:
Description
This PR:
- refactors the viaq data model to be a filter so that it is easier to swap out
- Moves all RH/viaq specific changes to the viaq filter
- Adds log_type, log_source to the source so we can make decisions in transforms
- Allows the ability to split some viaq transforms into configurable filters (e.g. loglevel, journal debug level, etc)
Links
https://issues.redhat.com/browse/LOG-5298
/hold
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcantrill
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jcantrill]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jcantrill: This pull request references LOG-5298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.
In response to this:
Description
This PR:
- refactors the viaq data model to be a filter so that it is easier to swap out
- Moves all RH/viaq specific changes to the viaq filter
- Adds log_type, log_source to the source so we can make decisions in transforms
- Allows the ability to split some viaq transforms into configurable filters (e.g. loglevel, journal debug level, etc)
- blocked on #2463
Links
https://issues.redhat.com/browse/LOG-5298
/hold
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 79e2c14716573e15368dbe1ecd98e37b6da736d7 and 2 for PR HEAD 3d64388d4ac643eabe1b37710d4e62cec96e1afe in total
@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/functional | de241c5adaa3b7019d045aa8019ff791f49b2c0a | link | false | /test functional |
| ci/prow/e2e-ocp-target-minus-two | de241c5adaa3b7019d045aa8019ff791f49b2c0a | link | false | /test e2e-ocp-target-minus-two |
| ci/prow/e2e-ocp-target-minus-one | de241c5adaa3b7019d045aa8019ff791f49b2c0a | link | false | /test e2e-ocp-target-minus-one |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-target, ci/prow/functional-target
In response to this:
/override ci/prow/e2e-target /override ci/prow/functional-target
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.