cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

LOG-5062: align validation with documentation

Open vparfonov opened this issue 11 months ago • 18 comments

Description

This PR address to align validation feature with current documentation. During validation for ClusterLogging we will check is ClusterLogForwarder in the same namespace named the same exist if not, exception will throw.

/cc @cahartma @Clee2691 /assign @jcantrill

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA: https://issues.redhat.com/browse/LOG-5062
  • Enhancement proposal:

vparfonov avatar Mar 11 '24 11:03 vparfonov

@vparfonov: This pull request references LOG-5062 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR address to align validation feature with current documentation. During validation for ClusterLogging we will check is ClusterLogForwarder in the same namespace named the same exist if not, exception will throw.

/cc @cahartma @Clee2691 /assign @jcantrill

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA: https://issues.redhat.com/browse/LOG-5062
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 11 '24 11:03 openshift-ci-robot

/hold

vparfonov avatar Mar 11 '24 11:03 vparfonov

/test functional

vparfonov avatar Mar 12 '24 13:03 vparfonov

/retest

vparfonov avatar Mar 12 '24 18:03 vparfonov

/retest

vparfonov avatar Mar 20 '24 21:03 vparfonov

/test e2e-target

vparfonov avatar Mar 21 '24 08:03 vparfonov

/test e2e-target

vparfonov avatar Mar 21 '24 09:03 vparfonov

/retest

vparfonov avatar Mar 21 '24 16:03 vparfonov

/test e2e-target

vparfonov avatar Mar 22 '24 10:03 vparfonov

/test e2e-target

vparfonov avatar Mar 22 '24 14:03 vparfonov

@vparfonov one nit but we will keep this on hold until after the release

jcantrill avatar Mar 26 '24 12:03 jcantrill

/approve /lgtm

jcantrill avatar Mar 26 '24 15:03 jcantrill

/test ci/prow/e2e-target

jcantrill avatar Mar 26 '24 15:03 jcantrill

@jcantrill: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test ci-index-cluster-logging-operator-bundle
  • /test e2e-target
  • /test functional-target
  • /test images
  • /test lint
  • /test unit

The following commands are available to trigger optional jobs:

  • /test e2e-ocp-target-minus-one
  • /test e2e-ocp-target-minus-two
  • /test functional

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Mar 26 '24 15:03 openshift-ci[bot]

/test e2e-target

jcantrill avatar Mar 26 '24 15:03 jcantrill

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 26 '24 15:03 openshift-ci[bot]

/retest

vparfonov avatar Mar 27 '24 08:03 vparfonov

/hold cancel

jcantrill avatar Apr 12 '24 18:04 jcantrill

/cherrypick release-5.9

jcantrill avatar Apr 12 '24 18:04 jcantrill

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-5.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/retest-required

Remaining retests: 0 against base HEAD 5b4f827bc1ee4aa692f5d4ea35e23eb6d10e159f and 2 for PR HEAD a707bb827404e37e04c42d5f53aa46dc7bbd9cbc in total

openshift-ci-robot avatar Apr 12 '24 19:04 openshift-ci-robot

/retest

jcantrill avatar Apr 15 '24 20:04 jcantrill

/retest

jcantrill avatar Apr 16 '24 15:04 jcantrill

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-target-minus-one a707bb827404e37e04c42d5f53aa46dc7bbd9cbc link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 16 '24 18:04 openshift-ci[bot]

/retest

vparfonov avatar Apr 17 '24 14:04 vparfonov

Manually merging. job was retired after PR was created

jcantrill avatar Apr 19 '24 13:04 jcantrill

@jcantrill: new pull request created: #2437

In response to this:

/cherrypick release-5.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.