cluster-logging-operator
cluster-logging-operator copied to clipboard
openshift
LOG-2919: fix order of reconcilation for ServiceMonitor
Description
This PR:
- fixes ServiceMonitor order of reconciliation to try to Get before Create
- Refactors ServiceMonitor code out of k8shandler/collection.go to decouple from ClusterLoggingRequest
- Makes ServiceMonitor reconciliation async
Links
- https://issues.redhat.com/browse/LOG-2919
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcantrill
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jcantrill]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@xperimental I updated this change to remove the async. Thoughts? Do you think this is better?
@jcantrill: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.