cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

NO-JIRA: Remove matchExpressions from labelSelector

Open alanconway opened this issue 2 years ago • 18 comments

We don't yet support matchExpressions so we should not include it in the API. When we do support it (LOG-1126) matchExpressions can be restored.

alanconway avatar Jun 22 '22 18:06 alanconway

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 22 '22 18:06 openshift-ci[bot]

/retest-required

alanconway avatar Jul 07 '22 21:07 alanconway

/retest-required

Remaining retests: 2 against base HEAD 3f272124c5faacec7ec8887842b260804b04265a and 8 for PR HEAD 3f6e8a8371d2eb494a0c55b97da6d1e39bbee2a4 in total

openshift-ci-robot avatar Aug 17 '22 01:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 3f272124c5faacec7ec8887842b260804b04265a and 7 for PR HEAD 3f6e8a8371d2eb494a0c55b97da6d1e39bbee2a4 in total

openshift-ci-robot avatar Aug 17 '22 02:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 3f272124c5faacec7ec8887842b260804b04265a and 6 for PR HEAD 3f6e8a8371d2eb494a0c55b97da6d1e39bbee2a4 in total

openshift-ci-robot avatar Aug 17 '22 03:08 openshift-ci-robot

/retest

jcantrill avatar Aug 26 '22 17:08 jcantrill

/lgtm

jcantrill avatar Aug 26 '22 17:08 jcantrill

/retest-required

Remaining retests: 2 against base HEAD 517309f792215cd77ab6f071a42277065352012b and 8 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 26 '22 18:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 517309f792215cd77ab6f071a42277065352012b and 7 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 26 '22 20:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 517309f792215cd77ab6f071a42277065352012b and 6 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 26 '22 20:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD 84bfa8789651873d6e364b1a114736882ff68c07 and 5 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 27 '22 04:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD b4d77872407e383a2204a8c962b47c2aa38b7831 and 4 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 27 '22 09:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD b4d77872407e383a2204a8c962b47c2aa38b7831 and 3 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 27 '22 12:08 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD b4d77872407e383a2204a8c962b47c2aa38b7831 and 2 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 27 '22 13:08 openshift-ci-robot

/retest-required

Remaining retests: 2 against base HEAD e6ddbfe1338e3567ac3daeb2583f7800864d7e68 and 1 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 27 '22 18:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD e6ddbfe1338e3567ac3daeb2583f7800864d7e68 and 0 for PR HEAD cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 in total

openshift-ci-robot avatar Aug 27 '22 20:08 openshift-ci-robot

/hold

Revision cf24e00fdbc9cfa9473df45e43dd82f9b0ffc402 was retested 9 times: holding

openshift-ci-robot avatar Aug 27 '22 22:08 openshift-ci-robot

/retest

jcantrill avatar Sep 08 '22 16:09 jcantrill

/hold cancel

jcantrill avatar Sep 20 '22 18:09 jcantrill

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 20 '22 23:09 openshift-ci[bot]