cloud-credential-operator
cloud-credential-operator copied to clipboard
openshift
OCPBUGS-29554: Apply hypershift cluster-profile for ibm-cloud-managed
Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29554, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @jianping-shu
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershiftaddition will allow Hypershift to express different profile choices than ROKS
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
If other files need to be updated to support this change, please let me know.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: openshift-art-build-bot Once this PR has been reviewed and has the lgtm label, please assign dlom for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Verified with cluster-bot build. The hosted cluster installed successfully. On hosted cluster (1)jianpingshu@jshu-mac ~ % oc get cloudcredential cluster -o yaml apiVersion: operator.openshift.io/v1 kind: CloudCredential metadata: labels: hypershift.openshift.io/managed: "true" (2) The resources have the new annotation for sample jianpingshu@jshu-mac ~ % oc get ClusterRole system:openshift:cloud-credential-operator:cluster-reader -o yaml apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: annotations: include.release.openshift.io/hypershift: "true"
On management cluster (1)jianpingshu@jshu-mac ~ % oc get cloudcredential cluster -o yaml apiVersion: operator.openshift.io/v1 kind: CloudCredential metadata: //no label (2) The resources have the new annotation for sample jianpingshu@jshu-mac ~ % oc get ClusterRole system:openshift:cloud-credential-operator:cluster-reader -o yaml apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: annotations: include.release.openshift.io/hypershift: "true"
@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29554, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @jianping-shu
In response to this:
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershiftaddition will allow Hypershift to express different profile choices than ROKS
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jianping-shu looks like the manifest flows from a different file, hence why the verify job is failing. @2uasimojo / @suhanime can you point me to the file if possible?
@jianping-shu looks like the manifest flows from a different file, hence why the verify job is failing. @2uasimojo / @suhanime can you point me to the file if possible?
@ashwindasr Looks like your bindata isn't updated, which is why the test is failing. Perhaps a make update would do the trick? But I suggest running make all instead. And you can verify if it works by running make verify locally.
/hold
Requires https://github.com/openshift/api/pull/1775 to be merged first
@openshift-art-build-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-upgrade | 1049c2c9650acf0bcaa43dbcb62aee0a53a64b8e | link | true | /test e2e-upgrade |
| ci/prow/verify | 1049c2c9650acf0bcaa43dbcb62aee0a53a64b8e | link | true | /test verify |
| ci/prow/security | 1049c2c9650acf0bcaa43dbcb62aee0a53a64b8e | link | true | /test security |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/override ci/prow/security The bug being fixed here is marked as a blocker, the Snyk failures are moderate CVEs in deps. I'm asking if there's a bug tracking that but I don't want to block functional changes on fixing that.
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/security
In response to this:
/override ci/prow/security The bug being fixed here is marked as a blocker, the Snyk failures are moderate CVEs in deps. I'm asking if there's a bug tracking that but I don't want to block functional changes on fixing that.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.35%. Comparing base (
7bb8af6) to head (2fab3d6). Report is 66 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 48.39% 48.35% -0.05%
==========================================
Files 96 96
Lines 11783 11797 +14
==========================================
+ Hits 5702 5704 +2
- Misses 5448 5460 +12
Partials 633 633
| Files with missing lines | Coverage Δ | |
|---|---|---|
| pkg/assets/bootstrap/bindata.go | 23.85% <ø> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
/hold I believe since we missed getting this into master branch before 4.16 branching we need to land this in master branch first, working on that now.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: openshift-art-build-bot, sdodson Once this PR has been reviewed and has the lgtm label, please assign dlom for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@openshift-art-build-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify | 2fab3d6556c8f41b194607dd76300333e281667d | link | true | /test verify |
| ci/prow/e2e-aws-ovn | 2fab3d6556c8f41b194607dd76300333e281667d | link | true | /test e2e-aws-ovn |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
