client-go icon indicating copy to clipboard operation
client-go copied to clipboard

releases?

Open davidkarlsen opened this issue 3 years ago • 11 comments

I noticed you have very few tags. Wouldn't it make sense to create tags/releases?

davidkarlsen avatar Nov 25 '20 18:11 davidkarlsen

+1 to this, lack of releases means this doesn't play nice with Go modules. Defaults instead to the outdated 3.9.0 tag from April 2018, unless you explicitly replace it with a pseudo-version.

nikbanerjee-ibm avatar Jan 11 '21 13:01 nikbanerjee-ibm

+1 - I'm pretty new to go but struggling to do anything with this and go modules as keep hitting:

github.com/openshift/client-go: module github.com/openshift/client-go@latest found (v3.9.0+incompatible), but does not contain package github.com/openshift/client-go

Even if I try to use @master it switches back to 3.9.0

MattSWakefield avatar Mar 18 '21 18:03 MattSWakefield

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 16 '21 19:06 openshift-bot

/remove-lifecycle stale

Knolle74 avatar Jul 01 '21 10:07 Knolle74

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Sep 29 '21 14:09 openshift-bot

/remove-lifecycle stale

davidkarlsen avatar Sep 29 '21 22:09 davidkarlsen

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Dec 28 '21 22:12 openshift-bot

/remove-lifecycle stale

davidkarlsen avatar Dec 28 '21 23:12 davidkarlsen

/lifecycle frozen

davidkarlsen avatar Dec 28 '21 23:12 davidkarlsen

Hitting the same issue here, I'm trying to programatically do something with SCCs but keep hitting

/go/pkg/mod/github.com/openshift/[email protected]+incompatible/security/clientset/versioned/typed/security/v1/securitycontextconstraints.go:100:9: not enough arguments in call to c.client.Delete().Resource("securitycontextconstraints").Name(name).Body(options).Do
        have ()
        want (context.Context)

due to outdated interfaces.

EDIT: I was able to get it solved, reading the README: go get github.com/openshift/[email protected] and then using an import in your project like:

securityclientv1 "github.com/openshift/client-go/security/clientset/versioned/typed/security/v1"
...
securityClient, err := securityclientv1.NewForConfig(cfg)

Then "go mod tidy". Worked for me.

Henning-GitHub avatar Feb 14 '23 08:02 Henning-GitHub

I will bring this up internally, but typically we don't tag OpenShift releases on repositories.

Using the master branch should be avoided since that is a development branch and therefore would be considered unsupported and may have changes introduced mid-release that cause issues.

If you are using this repository, I would recommend only pulling from branches release-4.yy, where the yy represents the version of OpenShift you are building your tooling against.

JoelSpeed avatar May 30 '23 15:05 JoelSpeed