cincinnati icon indicating copy to clipboard operation
cincinnati copied to clipboard

OTA-134: remove deploymentconfig from cincinnati

Open PratikMahajan opened this issue 1 year ago • 3 comments

deploymentconfig has been deprecated and we no longer use it. use cincinnati-deployment.yaml as a replacement to deploymentconfig

PratikMahajan avatar Aug 28 '24 20:08 PratikMahajan

@PratikMahajan: This pull request references OTA-134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

deploymentconfig has been deprecated and we no longer use it. use cincinnati-deployment.yaml as a replacement to deploymentconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 18 '24 14:09 openshift-ci-robot

Failures look like the known HEAD fails investigated by David, should be safe to override

petr-muller avatar Sep 25 '24 11:09 petr-muller

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, PratikMahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [PratikMahajan,petr-muller]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 25 '24 11:09 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 8d97a50e2904827b25651322e9164b7bf52fe51e and 2 for PR HEAD b9a5698f14fc3e99458ae1c65075b5872936e2f7 in total

openshift-ci-robot avatar Sep 25 '24 12:09 openshift-ci-robot

/hold

Meh, the retester starts to kick-in when I LGTM, so holding, unhold as you override

petr-muller avatar Sep 25 '24 12:09 petr-muller

/override ci/prow/customrust-cargo-test /override ci/prow/cargo-test

overriding known test failures

PratikMahajan avatar Sep 25 '24 14:09 PratikMahajan

@PratikMahajan: Overrode contexts on behalf of PratikMahajan: ci/prow/cargo-test, ci/prow/customrust-cargo-test

In response to this:

/override ci/prow/customrust-cargo-test /override ci/prow/cargo-test

overriding known test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 25 '24 14:09 openshift-ci[bot]

@PratikMahajan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 25 '24 14:09 openshift-ci[bot]

/hold cancel

PratikMahajan avatar Sep 25 '24 14:09 PratikMahajan