ci-tools icon indicating copy to clipboard operation
ci-tools copied to clipboard

Add comprehensive beginner-friendly documentation

Open deepsm007 opened this issue 3 months ago • 9 comments

/cc @openshift/test-platform

/hold

Assisted by Claude

deepsm007 avatar Nov 19 '25 23:11 deepsm007

Pipeline controller notification This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

openshift-ci-robot avatar Nov 19 '25 23:11 openshift-ci-robot

[!WARNING]

Rate limit exceeded

@deepsm007 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c02f4b3fd3140e133f49031d9796b4f7275627dc and cf95330a8ff0d7ec84abd5877f14a4cbf6890ec1.

📒 Files selected for processing (1)
  • docs/README.md (1 hunks)

Walkthrough

Adds extensive documentation across the repository: new docs in docs/, expanded CONTRIBUTING.md, and many new README.md files under cmd/ and pkg/. Changes are documentation-only; no code, API, or exported-entity modifications.

Changes

Cohort / File(s) Summary
Root documentation
docs/ARCHITECTURE.md, docs/README.md, docs/SETUP.md, CONTRIBUTING.md
New architecture guide with diagrams and usage, documentation hub/index, beginner setup guide with prerequisites and troubleshooting, and extensively expanded contributing guidelines and FAQ.
Command tool READMEs
cmd/.../README.md (e.g. cmd/ci-operator/README.md, cmd/autotestgridgenerator/README.md, cmd/backport-verifier/README.md, cmd/bugzilla-backporter/README.md, cmd/check-cluster-profiles-config/README.md, cmd/ci-operator-config-mirror/README.md, cmd/ci-operator-configresolver/README.md, cmd/ci-operator-prowgen/README.md, cmd/ci-secret-bootstrap/README.md, cmd/cluster-display/README.md, cmd/cluster-operator-status/README.md, cmd/clusterimageset-updater/README.md, cmd/determinize-ci-operator/README.md, cmd/determinize-peribolos/README.md, cmd/determinize-prow-config/README.md, cmd/docgen/README.md, cmd/dptp-pools-cm/README.md, cmd/entrypoint-wrapper/README.md, cmd/generate-registry-metadata/README.md, cmd/helpdesk-faq/README.md, cmd/job-trigger-controller-manager/README.md, cmd/payload-testing-prow-plugin/README.md, cmd/pipeline-controller/README.md, cmd/pj-rehearse/README.md, cmd/rebalancer/README.md, cmd/result-aggregator/README.md, cmd/retester/README.md)
Adds individual README documentation for many command-line tools and Prow plugins describing purpose, usage, options, workflows, and examples.
Package documentation
pkg/.../README.md (e.g. pkg/api/README.md, pkg/controller/README.md, pkg/steps/README.md)
Adds package-level READMEs describing APIs, core data types, controller patterns, Step interface, execution flow, and related references.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Focus review on high-density documentation with examples or diagrams:
    • docs/ARCHITECTURE.md
    • CONTRIBUTING.md
    • command READMEs that include CLI flags, YAML snippets, or workflows (verify accuracy and consistency).
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 19 '25 23:11 coderabbitai[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [deepsm007,liangxia]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 20 '25 02:11 openshift-ci[bot]

Scheduling required tests: /test e2e

openshift-ci-robot avatar Nov 20 '25 02:11 openshift-ci-robot

Nice doc. :+1:

liangxia avatar Nov 20 '25 02:11 liangxia

I think it's a good idea, but I think we should invest more time in it. I feel like the documentation is very vague, not going into detail much, and repeating itself a bit: ARCHITECTURE.md, CODEBASE_WALKTHROUGH.md, SETUP.md, SUMMARIES.md, USAGE.md, OVERVIEW.md, sounds pretty similar to me, I think I would prefer maybe just one or two. I would also like to add such a readme for every component (maybe also each package) we have, so that it is easy to start with claude on any tool.

Also I am not sure if we need these: CONTRIBUTING_GUIDE.md, FAQ.md, ONBOARDING.md, these would be a better fit in o/release maybe.

Prucek avatar Nov 20 '25 08:11 Prucek

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Nov 20 '25 14:11 openshift-ci[bot]

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes cf95330a8ff0d7ec84abd5877f14a4cbf6890ec1 link false /test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 20 '25 15:11 openshift-ci[bot]

I think this is way better, but I would rather make it even better. Some of them are pretty good, but others lack details. I think we should combine the knowledge of ci-docs, o/release, branching doc, and the ci-tools with our knowledge and be pedantic on what it says. I would focus on one tool in more detail, let's say pj-rehearse:

* understand how the code works along with the rehearse package

* understand how it is deployed, also that we can test with the alpha deployment

* what commands it does have

* and combine with the doc in ci/docs
  so that it has a nice overall picture.
  I know this is really time-consuming, but I think it's worth it. You can't make that on your own. Everyone would need to help when they touch a tool and it doesn't have .md, make it. We can discuss this in our meetings. Until then, I would like to help you.

I'll spend more time rewriting this.

deepsm007 avatar Nov 21 '25 14:11 deepsm007