ci-tools icon indicating copy to clipboard operation
ci-tools copied to clipboard

Overridding of pre/post definitions in tests requires manual flag

Open deepsm007 opened this issue 4 months ago • 7 comments

Add AllowPrePostStepOverrides to MultiStageTestConfiguration. mergeWorkflow now validates pre/post overrides, requiring the flag set to true to prevent accidental resource leaks. Updated YAML docs and added comprehensive tests.

https://issues.redhat.com/browse/DPTP-4575

/cc @openshift/test-platform

deepsm007 avatar Oct 15 '25 14:10 deepsm007

/ai pr_description

deepsm007 avatar Oct 15 '25 14:10 deepsm007

@deepsm007: Add AllowPrePostStepOverrides to MultiStageTestConfiguration.
mergeWorkflow now validates pre/post overrides, requiring the flag set to true to prevent accidental resource leaks. Updated YAML docs and added comprehensive tests.

openshift-ci[bot] avatar Oct 15 '25 14:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 15 '25 14:10 openshift-ci[bot]

/test images

deepsm007 avatar Oct 16 '25 06:10 deepsm007

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 8d3f9a7c84f4147b9d24738fdbb83b6aa6c61617 link false /test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 16 '25 08:10 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jan 14 '26 09:01 openshift-bot

[!IMPORTANT]

Review skipped

Auto reviews are limited based on label configuration.

:no_entry_sign: Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Jan 14 '26 09:01 coderabbitai[bot]