Upgrades to frequency-reducer: improved logic, multithreading, added cluster profiles, tests

[jmguzik]

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [jmguzik]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

@jmguzik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	8cf9a4bd0f205ee9ace0622f136181589cf3cca2	link	true	/test unit
ci/prow/images	8cf9a4bd0f205ee9ace0622f136181589cf3cca2	link	true	/test images
ci/prow/security	8cf9a4bd0f205ee9ace0622f136181589cf3cca2	link	false	/test security
ci/prow/breaking-changes	8cf9a4bd0f205ee9ace0622f136181589cf3cca2	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[coderabbitai[bot]]

Walkthrough

The PR introduces cluster-profile filtering, parallel processing infrastructure, and yearly cron generation logic to the frequency-reducer component. New configuration parsing, worker pool dispatch, and per-test filtering mechanisms are added alongside comprehensive unit tests.

Changes

Cohort / File(s)	Summary
Cluster-profile filtering and parallel processing infrastructure cmd/branchingconfigmanagers/frequency-reducer/main.go	Introduces ClusterProfilesConfig struct for YAML-based cluster profile configuration. Adds loadClusterProfilesConfig for parsing profiles into an allowed-profiles map. Implements processConfigurationsInParallel for concurrent configuration processing with worker pool pattern. Adds configJob struct to encapsulate job parameters and processConfiguration worker function. Extends updateIntervalFieldsForMatchedSteps signature to accept allowedClusterProfiles parameter. Implements shouldProcessTest for per-test cluster profile filtering logic.
Cron expression generation and scheduling utilities cmd/branchingconfigmanagers/frequency-reducer/main.go	Adds isExecutedAtMostOncePerYear helper to validate yearly execution patterns in cron expressions. Introduces generateYearlyCron function for creating yearly cron expressions. Integrates yearly cron logic into configuration processing paths with version-based conditional logic.
Comprehensive unit test coverage cmd/branchingconfigmanagers/frequency-reducer/main_test.go	New test file providing extensive coverage for version extraction, scheduling logic verification, cron generation and validation, interval/cron field updates, options validation, command-line argument parsing, test processing determination, cluster profile configuration loading, and cluster-profile-filtered updates across multiple scenarios and edge cases.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~70 minutes

• Concurrency patterns: processConfigurationsInParallel introduces worker pool logic; verify thread-safety of error aggregation and job dispatch mechanisms
• Cron expression logic: generateYearlyCron and isExecutedAtMostOncePerYear manipulate scheduling expressions; validate correctness of generated cron patterns and edge cases
• Cluster profile filtering: Cross-cutting concern affecting multiple functions; ensure shouldProcessTest filtering is consistently applied and doesn't introduce logical gaps
• Function signature changes: updateIntervalFieldsForMatchedSteps now accepts allowedClusterProfiles; verify all call sites properly pass the parameter and filtering intent is preserved
• Test coverage adequacy: Confirm new parallel processing paths and error scenarios in the test file provide sufficient coverage for production reliability

✨ Finishing touches

• [ ] 📝 Generate docstrings

🧪 Generate unit tests (beta)

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci[bot]]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.