openshift
[DPTP-4313] Respecting always_run from config file
The field always_run is auto-generated based in the following condition:
AlwaysRun: opts.runIfChanged == "" && opts.skipIfOnlyChanged == "" && !opts.defaultDisable && opts.pipelineRunIfChanged == "",
But it is only updated if and only if there is no reference to an older configuration, if there is a valid reference, the old value is used and the new one is ignored:
if oldJob, existed := oldJobs[newJobName]; existed {
mergedJobs = append(mergedJobs, mergePresubmits(&oldJob, &newJob))
} else {
mergedJobs = append(mergedJobs, newJob)
}
I simply removed the property overriding of AlwaysRun, allowing it to use the logic that already exists and is battle tested.
In addition, some other small changes have been made to improve readability.
This modification can affect a lot of jobs.
/hold
Evaluation is needed if the function that assigns old values makes sense
@hector-vido: Overrode contexts on behalf of hector-vido: ci/prow/breaking-changes
In response to this:
/override ci/prow/breaking-changes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@hector-vido: Overrode contexts on behalf of hector-vido: ci/prow/breaking-changes
In response to this:
/override ci/prow/breaking-changes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hector-vido, jmguzik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hector-vido,jmguzik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 0fb2c1abc94a5705b494ec0c21b6916dc8374025 and 2 for PR HEAD 3ce85910d9405b5f53ff8d59fe96678ecb40be3b in total