openshift
TRT-1135: Stop uploading Test Run Data and the Job Run tables
As a followup to #4129 , this PR continues by removing the actual upload of test run data which we should not be referencing anymore after that previous PR merged.
In addition, last year I undertook work to partition the alert/disruption tables, which involved adding job run data to every row. However we never made it far enough to actually stop using/uploading three copies of job run data to three separate tables. (JobRuns, Alerts_JobRuns, BackendDisruption_JobRuns)
This PR completes that work, Job run data is now read by examining the JobRun columns in Alerts and BackendDisruption tables, using the partition column (JobRunStartDate) to keep query sizes comparable. The three JobRun tables are no longer being populated leading to a more concise and less complicated code base.
@dgoodwin: This pull request references TRT-1135 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
As a followup to #4096 , this PR continues by removing the actual upload of test run data which we should not be referencing anymore after that previous PR merged.
In addition, last year I undertook work to partition the alert/disruption tables, which involved adding job run data to every row. However we never made it far enough to actually stop using/uploading three copies of job run data to three separate tables. (JobRuns, Alerts_JobRuns, BackendDisruption_JobRuns)
This PR completes that work, Job run data is now read by examining the JobRun columns in Alerts and BackendDisruption tables, using the partition column (JobRunStartDate) to keep query sizes comparable. The three JobRun tables are no longer being populated leading to a more concise and less complicated code base.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@dgoodwin: This pull request references TRT-1135 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
As a followup to #4129 , this PR continues by removing the actual upload of test run data which we should not be referencing anymore after that previous PR merged.
In addition, last year I undertook work to partition the alert/disruption tables, which involved adding job run data to every row. However we never made it far enough to actually stop using/uploading three copies of job run data to three separate tables. (JobRuns, Alerts_JobRuns, BackendDisruption_JobRuns)
This PR completes that work, Job run data is now read by examining the JobRun columns in Alerts and BackendDisruption tables, using the partition column (JobRunStartDate) to keep query sizes comparable. The three JobRun tables are no longer being populated leading to a more concise and less complicated code base.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgoodwin, neisw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/jobrunaggregator/OWNERS~~ [dgoodwin,neisw]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD 383fa761f404dc454f1086eafa56185d2b6d0a74 and 2 for PR HEAD 2e31ca598ffe40a935f941e23e4e57f15aa0f316 in total
/retest-required
Remaining retests: 0 against base HEAD cd4a99392491ac61eb889c60514150e082053ab4 and 1 for PR HEAD 2e31ca598ffe40a935f941e23e4e57f15aa0f316 in total
/retest-required
Remaining retests: 0 against base HEAD 2a1306346255d37fee6781cf19f56e122890e269 and 0 for PR HEAD 2e31ca598ffe40a935f941e23e4e57f15aa0f316 in total
/hold
Revision 2e31ca598ffe40a935f941e23e4e57f15aa0f316 was retested 3 times: holding
@dgoodwin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/security | 2e31ca598ffe40a935f941e23e4e57f15aa0f316 | link | false | /test security |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/retest-required
Remaining retests: 0 against base HEAD f6f93c90019d0711bebb082301eb5b2d13e2ceff and 2 for PR HEAD 2e31ca598ffe40a935f941e23e4e57f15aa0f316 in total