ci-tools
ci-tools copied to clipboard
openshift
TRT-1627: Use variant registry for disruption and remove some outdated half implmented view management
Disruption stack is ported to use a new view, JobsWithVariants, instead of using it's own copy of the logic to determine variants. Most of the work to switch to the registry happened on the views + scheduled queries side, this change is predominantly switching to use that data instead of the old, and stopping the population/calculation of the old.
Removed the code creating various views, they were long out of date, and only a handful of views had schema management. Would be nice to have a proper solution for this but this wasn't sufficient for our needs today, and I don't want two copies of that schema floating around out of date.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgoodwin
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/jobrunaggregator/OWNERS~~ [dgoodwin]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dgoodwin: This pull request references TRT-1627 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Disruption stack is ported to use a new view, JobsWithVariants, instead of using it's own copy of the logic to determine variants. Most of the work to switch to the registry happened on the views + scheduled queries side, this change is predominantly switching to use that data instead of the old, and stopping the population/calculation of the old.
Removed the code creating various views, they were long out of date, and only a handful of views had schema management. Would be nice to have a proper solution for this but this wasn't sufficient for our needs today, and I don't want two copies of that schema floating around out of date.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/lint | a3c13f095409bd40ad53b8f8ef6e199e344fd8b2 | link | true | /test lint |
| ci/prow/security | a3c13f095409bd40ad53b8f8ef6e199e344fd8b2 | link | false | /test security |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@dgoodwin: This pull request references TRT-1627 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Disruption stack is ported to use a new view, JobsWithVariants, instead of using it's own copy of the logic to determine variants. Most of the work to switch to the registry happened on the views + scheduled queries side, this change is predominantly switching to use that data instead of the old, and stopping the population/calculation of the old.
Removed the code creating various views, they were long out of date, and only a handful of views had schema management. Would be nice to have a proper solution for this but this wasn't sufficient for our needs today, and I don't want two copies of that schema floating around out of date.
A great deal of the dangerous part of this work was already performed by adjusting views in bigquery, these changes predominantly start attempting to use the right data as a result instead of the old columns, which we hope to soon drop.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@dgoodwin: This pull request references TRT-1627 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Disruption stack is ported to use a new view, JobsWithVariants, instead of using it's own copy of the logic to determine variants. Most of the work to switch to the registry happened on the views + scheduled queries side, this change is predominantly switching to use that data instead of the old, and stopping the population/calculation of the old.
Removed the code creating various views, they were long out of date, and only a handful of views had schema management. Would be nice to have a proper solution for this but this wasn't sufficient for our needs today, and I don't want two copies of that schema floating around out of date.
A great deal of the dangerous part of this work was already performed by adjusting views in bigquery, these changes predominantly start attempting to use the right data as a result instead of the old columns, which we hope to soon drop. For example, the views used by the aggregator have already been flipped over to use test run data from the component readiness junit table. This PR includes code to stop uploading all test run data.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@dgoodwin: This pull request references TRT-1627 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Disruption stack is ported to use a new view, JobsWithVariants, instead of using it's own copy of the logic to determine variants. Most of the work to switch to the registry happened on the views + scheduled queries side, this change is predominantly switching to use that data instead of the old. A followup PR will attempt to do more, and stop uploading things we no longer need.
Removed the code creating various views, they were long out of date, and only a handful of views had schema management. Would be nice to have a proper solution for this but this wasn't sufficient for our needs today, and I don't want two copies of that schema floating around out of date.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/assign @xueqzhan
Ken could you have a look at this first round of changes?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgoodwin, xueqzhan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/jobrunaggregator/OWNERS~~ [dgoodwin,xueqzhan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 0b824a275712526611ee9ca0bca27a2909e5a80d and 2 for PR HEAD aeda25909e7e3c9aa759204e8cfac8e6e475193d in total
@dgoodwin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/security | aeda25909e7e3c9aa759204e8cfac8e6e475193d | link | false | /test security |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.