ci-operator icon indicating copy to clipboard operation
ci-operator copied to clipboard

Detect when a config map doesn't exist on a running pod for > X time, fail

Open smarterclayton opened this issue 6 years ago • 4 comments

A common error mode is forgetting to create a dependent config map. We should do a slightly better job of conveying that condition back (either as a job failure or a log message)

smarterclayton avatar Oct 03 '18 13:10 smarterclayton

We should? Or k8s should?

stevekuznetsov avatar Oct 03 '18 14:10 stevekuznetsov

Configmaps we have issues with are:

  • CI Operator config
  • any of the assorted configmaps for the templates

The first is fixed now with an updated approach to uploading those The second should be mitigated from copy-pasta errors for extant templates by generating the Prow config. For net-new templates, agreed this would be an issue.

stevekuznetsov avatar Oct 03 '18 14:10 stevekuznetsov

I think in this case the ci-operator "wait for pod success" job could easily report the error that k8s puts on the container when the config doesn't exist after a period of time.

smarterclayton avatar Oct 03 '18 14:10 smarterclayton

Yes, and with secrets too

stevekuznetsov avatar Oct 03 '18 16:10 stevekuznetsov